2011-06-30 Patrick Gansterer <paroga@webkit.org>
authorparoga@webkit.org <paroga@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jun 2011 16:05:11 +0000 (16:05 +0000)
committerparoga@webkit.org <paroga@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Jun 2011 16:05:11 +0000 (16:05 +0000)
        Reviewed by Darin Adler.

        Remove dependnecy on IDL generation for disabled features in JSC bindings
        https://bugs.webkit.org/show_bug.cgi?id=63718

        Move the #if ENABLE() line directly after #include "config.h".
        This enables us to compile all files even when we don't generate the IDL output.

        * bindings/js/IDBBindingUtilities.cpp:
        * bindings/js/JSConsoleCustom.cpp:
        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSDOMApplicationCacheCustom.cpp:
        * bindings/js/JSDeviceMotionEventCustom.cpp:
        * bindings/js/JSDeviceOrientationEventCustom.cpp:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        * bindings/js/JSInjectedScriptManager.cpp:
        * bindings/js/JSInspectorFrontendHostCustom.cpp:
        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
        * bindings/js/JSSQLResultSetRowListCustom.cpp:
        * bindings/js/JSSQLTransactionCustom.cpp:
        * bindings/js/JSSQLTransactionSyncCustom.cpp:
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        * bindings/js/JSStorageCustom.cpp:
        * bindings/js/JSTouchCustom.cpp:
        * bindings/js/JSTouchListCustom.cpp:
        * bindings/js/JSXPathResultCustom.cpp:
        * bindings/js/JavaScriptCallFrame.cpp:
        * bindings/js/PageScriptDebugServer.cpp:
        * bindings/js/ScriptDebugServer.cpp:
        * bindings/js/ScriptGCEvent.cpp:
        * bindings/js/ScriptProfile.cpp:
        * bindings/js/WorkerScriptDebugServer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

26 files changed:
Source/WebCore/ChangeLog
Source/WebCore/bindings/js/IDBBindingUtilities.cpp
Source/WebCore/bindings/js/JSConsoleCustom.cpp
Source/WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp
Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp
Source/WebCore/bindings/js/JSDOMApplicationCacheCustom.cpp
Source/WebCore/bindings/js/JSDeviceMotionEventCustom.cpp
Source/WebCore/bindings/js/JSDeviceOrientationEventCustom.cpp
Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp
Source/WebCore/bindings/js/JSInjectedScriptManager.cpp
Source/WebCore/bindings/js/JSInspectorFrontendHostCustom.cpp
Source/WebCore/bindings/js/JSJavaScriptCallFrameCustom.cpp
Source/WebCore/bindings/js/JSSQLResultSetRowListCustom.cpp
Source/WebCore/bindings/js/JSSQLTransactionCustom.cpp
Source/WebCore/bindings/js/JSSQLTransactionSyncCustom.cpp
Source/WebCore/bindings/js/JSSVGElementInstanceCustom.cpp
Source/WebCore/bindings/js/JSStorageCustom.cpp
Source/WebCore/bindings/js/JSTouchCustom.cpp
Source/WebCore/bindings/js/JSTouchListCustom.cpp
Source/WebCore/bindings/js/JSXPathResultCustom.cpp
Source/WebCore/bindings/js/JavaScriptCallFrame.cpp
Source/WebCore/bindings/js/PageScriptDebugServer.cpp
Source/WebCore/bindings/js/ScriptDebugServer.cpp
Source/WebCore/bindings/js/ScriptGCEvent.cpp
Source/WebCore/bindings/js/ScriptProfile.cpp
Source/WebCore/bindings/js/WorkerScriptDebugServer.cpp

index 3d6734d..a152bab 100644 (file)
@@ -1,3 +1,39 @@
+2011-06-30  Patrick Gansterer  <paroga@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        Remove dependnecy on IDL generation for disabled features in JSC bindings
+        https://bugs.webkit.org/show_bug.cgi?id=63718
+
+        Move the #if ENABLE() line directly after #include "config.h".
+        This enables us to compile all files even when we don't generate the IDL output.
+
+        * bindings/js/IDBBindingUtilities.cpp:
+        * bindings/js/JSConsoleCustom.cpp:
+        * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
+        * bindings/js/JSCustomXPathNSResolver.cpp:
+        * bindings/js/JSDOMApplicationCacheCustom.cpp:
+        * bindings/js/JSDeviceMotionEventCustom.cpp:
+        * bindings/js/JSDeviceOrientationEventCustom.cpp:
+        * bindings/js/JSInjectedScriptHostCustom.cpp:
+        * bindings/js/JSInjectedScriptManager.cpp:
+        * bindings/js/JSInspectorFrontendHostCustom.cpp:
+        * bindings/js/JSJavaScriptCallFrameCustom.cpp:
+        * bindings/js/JSSQLResultSetRowListCustom.cpp:
+        * bindings/js/JSSQLTransactionCustom.cpp:
+        * bindings/js/JSSQLTransactionSyncCustom.cpp:
+        * bindings/js/JSSVGElementInstanceCustom.cpp:
+        * bindings/js/JSStorageCustom.cpp:
+        * bindings/js/JSTouchCustom.cpp:
+        * bindings/js/JSTouchListCustom.cpp:
+        * bindings/js/JSXPathResultCustom.cpp:
+        * bindings/js/JavaScriptCallFrame.cpp:
+        * bindings/js/PageScriptDebugServer.cpp:
+        * bindings/js/ScriptDebugServer.cpp:
+        * bindings/js/ScriptGCEvent.cpp:
+        * bindings/js/ScriptProfile.cpp:
+        * bindings/js/WorkerScriptDebugServer.cpp:
+
 2011-06-30  Alexander Pavlov  <apavlov@chromium.org>
 
         Reviewed by Kent Tamura.
index 638a23e..1232054 100644 (file)
  */
 
 #include "config.h"
-#include "IDBBindingUtilities.h"
 
 #if ENABLE(INDEXED_DATABASE)
 
+#include "IDBBindingUtilities.h"
+
 #include "IDBKey.h"
 
 namespace WebCore {
@@ -46,4 +47,4 @@ PassRefPtr<IDBKey> createIDBKeyFromValue(JSC::ExecState* exec, JSC::JSValue valu
 
 } // namespace WebCore
 
-#endif
+#endif // ENABLE(INDEXED_DATABASE)
index 4f62201..f1d1fe9 100644 (file)
@@ -25,6 +25,8 @@
 
 #include "config.h"
 
+#if ENABLE(JAVASCRIPT_DEBUGGER)
+
 #include "JSConsole.h"
 
 #include "Console.h"
@@ -39,8 +41,6 @@ using namespace JSC;
 
 namespace WebCore {
 
-#if ENABLE(JAVASCRIPT_DEBUGGER)
-
 typedef Vector<RefPtr<ScriptProfile> > ProfilesArray;
 
 JSValue JSConsole::profiles(ExecState* exec) const
@@ -77,6 +77,6 @@ JSValue JSConsole::profileEnd(ExecState* exec)
     return jsUndefined();
 }
 
-#endif
-
 } // namespace WebCore
+
+#endif // ENABLE(JAVASCRIPT_DEBUGGER)
index c7fe0ea..8576518 100644 (file)
  */
 
 #include "config.h"
-#include "JSSQLStatementErrorCallback.h"
 
 #if ENABLE(DATABASE)
 
+#include "JSSQLStatementErrorCallback.h"
+
 #include "JSSQLError.h"
 #include "JSSQLTransaction.h"
 #include "ScriptExecutionContext.h"
index 2494c0d..5b2ed7e 100644 (file)
  */
 
 #include "config.h"
-#include "JSCustomXPathNSResolver.h"
 
 #if ENABLE(XPATH)
 
+#include "JSCustomXPathNSResolver.h"
+
 #include "Console.h"
 #include "Document.h"
 #include "ExceptionCode.h"
index 0598be9..1e1be6a 100644 (file)
  */
 
 #include "config.h"
-#include "JSDOMApplicationCache.h"
 
 #if ENABLE(OFFLINE_WEB_APPLICATIONS)
 
+#include "JSDOMApplicationCache.h"
+
 #include "DOMApplicationCache.h"
 #include "DOMWindow.h"
 #include "Event.h"
index 9142aa2..f4ccb86 100644 (file)
  */
 
 #include "config.h"
-#include "JSDeviceMotionEvent.h"
 
 #if ENABLE(DEVICE_ORIENTATION)
 
+#include "JSDeviceMotionEvent.h"
+
 #include "DeviceMotionData.h"
 #include "DeviceMotionEvent.h"
 
index c71364a..d67119f 100644 (file)
  */
 
 #include "config.h"
-#include "JSDeviceOrientationEvent.h"
 
 #if ENABLE(DEVICE_ORIENTATION)
 
+#include "JSDeviceOrientationEvent.h"
+
 #include "DeviceOrientation.h"
 #include "DeviceOrientationEvent.h"
 
index dfd2743..2e781b8 100644 (file)
  */
 
 #include "config.h"
-#include "JSInjectedScriptHost.h"
 
 #if ENABLE(INSPECTOR)
 
+#include "JSInjectedScriptHost.h"
+
 #if ENABLE(DATABASE)
 #include "Database.h"
 #include "JSDatabase.h"
index b784e6a..c5644f3 100644 (file)
  */
 
 #include "config.h"
-#include "InjectedScriptManager.h"
 
 #if ENABLE(INSPECTOR)
 
+#include "InjectedScriptManager.h"
+
 #include "ExceptionCode.h"
 #include "InjectedScript.h"
 #include "JSDOMWindow.h"
index 20bcc3a..ab6a1ad 100644 (file)
  */
 
 #include "config.h"
-#include "JSInspectorFrontendHost.h"
 
 #if ENABLE(INSPECTOR)
 
+#include "JSInspectorFrontendHost.h"
+
 #include "ContextMenuItem.h"
 #include "InspectorController.h"
 #include "InspectorFrontendHost.h"
index 2867a7d..1dba251 100644 (file)
  */
 
 #include "config.h"
-#include "JSJavaScriptCallFrame.h"
 
 #if ENABLE(JAVASCRIPT_DEBUGGER)
 
+#include "JSJavaScriptCallFrame.h"
+
 #include "JavaScriptCallFrame.h"
 #include <runtime/ArrayPrototype.h>
 #include <runtime/Error.h>
index 0fcd1ea..dd9a07b 100644 (file)
  */
 
 #include "config.h"
-#include "JSSQLResultSetRowList.h"
 
 #if ENABLE(DATABASE)
 
+#include "JSSQLResultSetRowList.h"
+
 #include "ExceptionCode.h"
 #include "SQLValue.h"
 #include "SQLResultSetRowList.h"
@@ -80,6 +81,6 @@ JSValue JSSQLResultSetRowList::item(ExecState* exec)
     return object;
 }
 
-}
+} // namespace WebCore
 
-#endif
+#endif // ENABLE(DATABASE)
index e32ea55..2ce9015 100644 (file)
  */
 
 #include "config.h"
-#include "JSSQLTransaction.h"
 
 #if ENABLE(DATABASE)
 
+#include "JSSQLTransaction.h"
+
 #include "DOMWindow.h"
 #include "ExceptionCode.h"
 #include "JSSQLStatementCallback.h"
@@ -116,6 +117,6 @@ JSValue JSSQLTransaction::executeSql(ExecState* exec)
     return jsUndefined();
 }
 
-}
+} // namespace WebCore
 
 #endif // ENABLE(DATABASE)
index 08f42e8..da7a98e 100644 (file)
  */
 
 #include "config.h"
-#include "JSSQLTransactionSync.h"
 
 #if ENABLE(DATABASE)
 
+#include "JSSQLTransactionSync.h"
+
 #include "ExceptionCode.h"
 #include "JSSQLResultSet.h"
 #include "SQLResultSet.h"
@@ -93,6 +94,6 @@ JSValue JSSQLTransactionSync::executeSql(ExecState* exec)
     return result;
 }
 
-}
+} // namespace WebCore
 
 #endif // ENABLE(DATABASE)
index 41a84f6..dd20fba 100644 (file)
  */
 
 #include "config.h"
-#include "JSSVGElementInstance.h"
 
 #if ENABLE(SVG)
+
+#include "JSSVGElementInstance.h"
+
 #include "JSNode.h"
 #include "SVGElementInstance.h"
 
index 6a126b7..41747be 100644 (file)
  */
 
 #include "config.h"
-#include "JSStorageCustom.h"
 
 #if ENABLE(DOM_STORAGE)
 
+#include "JSStorageCustom.h"
+
 #include "PlatformString.h"
 #include <runtime/PropertyNameArray.h>
 #include "Storage.h"
index 7f32989..80e21f6 100644 (file)
  */
 
 #include "config.h"
-#include "JSTouch.h"
 
 #if ENABLE(TOUCH_EVENTS)
 
+#include "JSTouch.h"
+
 #include "Touch.h"
 
 using namespace JSC;
@@ -44,4 +45,4 @@ JSValue toJSNewlyCreated(ExecState* exec, JSDOMGlobalObject* globalObject, Touch
 
 } // namespace WebCore
 
-#endif
+#endif // ENABLE(TOUCH_EVENTS)
index a7d7f9f..b60efdb 100644 (file)
  */
 
 #include "config.h"
-#include "JSTouchList.h"
 
 #if ENABLE(TOUCH_EVENTS)
 
+#include "JSTouchList.h"
+
 #include "TouchList.h"
 
 using namespace JSC;
@@ -44,4 +45,4 @@ JSValue toJSNewlyCreated(ExecState* exec, JSDOMGlobalObject* globalObject, Touch
 
 } // namespace WebCore
 
-#endif
+#endif // ENABLE(TOUCH_EVENTS)
index ad9005f..35489dc 100644 (file)
  */
 
 #include "config.h"
-#include "JSXPathResult.h"
 
 #if ENABLE(XPATH)
 
+#include "JSXPathResult.h"
+
 #include "JSDOMBinding.h"
 #include "XPathResult.h"
 #include "XPathValue.h"
index 5bafeda..5c4b95d 100644 (file)
  */
 
 #include "config.h"
-#include "JavaScriptCallFrame.h"
-
-#include "JSDOMBinding.h"
 
 #if ENABLE(JAVASCRIPT_DEBUGGER) && USE(JSC)
 
+#include "JavaScriptCallFrame.h"
+
+#include "JSDOMBinding.h"
 #include "PlatformString.h"
 #include <debugger/DebuggerCallFrame.h>
 #include <runtime/Completion.h>
index 3d9cb9d..c8f16f5 100755 (executable)
  */
 
 #include "config.h"
-#include "PageScriptDebugServer.h"
 
 #if ENABLE(JAVASCRIPT_DEBUGGER)
 
+#include "PageScriptDebugServer.h"
+
 #include "Frame.h"
 #include "FrameView.h"
 #include "JSDOMWindowCustom.h"
index 47bb145..7d48b00 100644 (file)
  */
 
 #include "config.h"
-#include "ScriptDebugServer.h"
 
 #if ENABLE(JAVASCRIPT_DEBUGGER)
 
+#include "ScriptDebugServer.h"
+
 #include "EventLoop.h"
 #include "Frame.h"
 #include "JSJavaScriptCallFrame.h"
index b694c7c..9fe0c2e 100644 (file)
  */
 
 #include "config.h"
-#include "ScriptGCEvent.h"
 
 #if ENABLE(INSPECTOR)
 
+#include "ScriptGCEvent.h"
+
 #include "JSDOMWindow.h"
 #include <heap/Heap.h>
 #include <runtime/JSGlobalData.h>
@@ -52,4 +53,4 @@ void ScriptGCEvent::getHeapSize(size_t& usedHeapSize, size_t& totalHeapSize, siz
 
 } // namespace WebCore
 
-#endif // !ENABLE(INSPECTOR)
+#endif // ENABLE(INSPECTOR)
index 6a34978..3c2b65f 100644 (file)
  */
 
 #include "config.h"
-#include "ScriptProfile.h"
 
 #if ENABLE(JAVASCRIPT_DEBUGGER)
+
+#include "ScriptProfile.h"
+
 #include "InspectorValues.h"
 #include "JSDOMBinding.h"
 #include <profiler/Profile.h>
index 5e2acd2..6d9e83d 100644 (file)
  */
 
 #include "config.h"
-#include "WorkerScriptDebugServer.h"
 
 #if ENABLE(JAVASCRIPT_DEBUGGER) && ENABLE(WORKERS)
 
+#include "WorkerScriptDebugServer.h"
+
 #include "WorkerContext.h"
 
 namespace WebCore {