2011-04-08 Sheriff Bot <webkit.review.bot@gmail.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Apr 2011 16:49:50 +0000 (16:49 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Apr 2011 16:49:50 +0000 (16:49 +0000)
        Unreviewed, rolling out r83295.
        http://trac.webkit.org/changeset/83295
        https://bugs.webkit.org/show_bug.cgi?id=58144

        Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).

        * platform/qt/Skipped:
2011-04-08  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83295.
        http://trac.webkit.org/changeset/83295
        https://bugs.webkit.org/show_bug.cgi?id=58144

        Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::handleInputMethodKeydown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/qt/Skipped
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/EditorClientQt.cpp

index 0cf2702..e99a93b 100644 (file)
@@ -1,3 +1,13 @@
+2011-04-08  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r83295.
+        http://trac.webkit.org/changeset/83295
+        https://bugs.webkit.org/show_bug.cgi?id=58144
+
+        Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
+
+        * platform/qt/Skipped:
+
 2011-04-08  Sergio Villar Senin  <svillar@igalia.com>
 
         Unreviewed, looks like the test is working fine now.
index 1f32822..656e85f 100644 (file)
@@ -3234,6 +3234,10 @@ plugins/embed-prefers-plugins-for-images.html
 # https://bugs.webkit.org/show_bug.cgi?id=57306
 http/tests/uri/username-with-no-hostname.html
 
+# [Qt]REGRESSION(r82243): fast/events/onsearch-enter.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=57472
+fast/events/onsearch-enter.html
+
 # [Qt] media/video-playbackrate.html fails
 # https://bugs.webkit.org/show_bug.cgi?id=57476
 media/video-playbackrate.html
index 2d08c5a..20189d6 100644 (file)
@@ -1,3 +1,14 @@
+2011-04-08  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r83295.
+        http://trac.webkit.org/changeset/83295
+        https://bugs.webkit.org/show_bug.cgi?id=58144
+
+        Broke 4 tests in QtWebKit (Requested by tonikitoo on #webkit).
+
+        * WebCoreSupport/EditorClientQt.cpp:
+        (WebCore::EditorClientQt::handleInputMethodKeydown):
+
 2011-04-08  Yi Shen  <yi.4.shen@nokia.com>
 
         Reviewed by Antonio Gomes.
index cc26667..0110144 100644 (file)
@@ -534,13 +534,12 @@ void EditorClientQt::handleInputMethodKeydown(KeyboardEvent* event)
 {
 #ifndef QT_NO_SHORTCUT
     const PlatformKeyboardEvent* kevent = event->keyEvent();
-    if (kevent->type() == PlatformKeyboardEvent::RawKeyDown && !event->defaultPrevented()) {
+    if (kevent->type() == PlatformKeyboardEvent::RawKeyDown) {
         QWebPage::WebAction action = QWebPagePrivate::editorActionForKeyEvent(kevent->qtEvent());
         switch (action) {
         case QWebPage::InsertParagraphSeparator:
         case QWebPage::InsertLineSeparator:
             m_page->triggerAction(action);
-            event->setDefaultHandled();
             break;
         default:
             break;