Remove testRunner.handleErrorPages()
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Aug 2016 20:27:33 +0000 (20:27 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Aug 2016 20:27:33 +0000 (20:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=160552

Patch by Jonathan Bedard <jbedard@apple.com> on 2016-08-05
Reviewed by Daniel Bates.

handleErrorPages() was implemented by the Qt WebKit port, per
https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
on other ports.  Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
feature was never implemented on Mac.

* fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
* fast/history/back-forward-reset-after-error-handling.html: Removed test.
* platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
* platform/gtk/TestExpectations: Ditto.
* platform/ios-simulator/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt [deleted file]
LayoutTests/fast/history/back-forward-reset-after-error-handling.html [deleted file]
LayoutTests/platform/efl/TestExpectations
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/mac/TestExpectations
LayoutTests/platform/win/TestExpectations

index 423906f..01c8bc8 100644 (file)
@@ -1,3 +1,23 @@
+2016-08-05  Jonathan Bedard  <jbedard@apple.com>
+
+        Remove testRunner.handleErrorPages()
+        https://bugs.webkit.org/show_bug.cgi?id=160552
+
+        Reviewed by Daniel Bates.
+
+        handleErrorPages() was implemented by the Qt WebKit port, per
+        https://bugs.webkit.org/show_bug.cgi?id=31509#c0, but never implemented
+        on other ports.  Per https://bugs.webkit.org/show_bug.cgi?id=31555, this
+        feature was never implemented on Mac.
+
+        * fast/history/back-forward-reset-after-error-handling-expected.txt: Removed test expectations.
+        * fast/history/back-forward-reset-after-error-handling.html: Removed test.
+        * platform/efl/TestExpectations: Remove reference to back-forward-reset-after-error-handling.
+        * platform/gtk/TestExpectations: Ditto.
+        * platform/ios-simulator/TestExpectations: Ditto.
+        * platform/mac/TestExpectations: Ditto.
+        * platform/win/TestExpectations: Ditto.
+
 2016-08-05  Brent Fulgham  <bfulgham@apple.com>
 
         validity assertion fails after removing a child of an <optgroup> element
diff --git a/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt b/LayoutTests/fast/history/back-forward-reset-after-error-handling-expected.txt
deleted file mode 100644 (file)
index df91c8e..0000000
+++ /dev/null
@@ -1,6 +0,0 @@
-SUCCESS
-
-============== Back Forward List ==============
-curr->  (file test):fast/history/back-forward-reset-after-error-handling.html  **nav target**
-        (file test):fast/history/non-existent.html  **nav target**
-===============================================
diff --git a/LayoutTests/fast/history/back-forward-reset-after-error-handling.html b/LayoutTests/fast/history/back-forward-reset-after-error-handling.html
deleted file mode 100644 (file)
index 43d663a..0000000
+++ /dev/null
@@ -1,48 +0,0 @@
-<html>
-    <script>
-    // Pre-conditions
-    // - Error page handling is supported on DRT.
-
-    // Navigation steps:
-    // 1- loads this page.
-    // 2- loads a non-existent page (an error page is loaded).
-    // 4- executes a back, forward and back navigations.
-
-    // Expected results:
-    // - forward-list should comprise the non-existent loaded page(2).
-
-    var isOkToContinue = "                                  "+
-    "{                                                      "+
-    "    var console = document.getElementById('console');  "+
-    "    if (console != null)                               "+
-    "        console.innerHTML = 'SUCCESS';                 "+
-    "    else                                               "+
-    "        console.innerHTML = 'FAIL';                    "+
-    "}";
-
-    if (window.testRunner) {
-        testRunner.dumpAsText();
-        testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
-        testRunner.handleErrorPages();
-        testRunner.dumpBackForwardList();
-    }
-
-    function onPageShow(evt)
-    {
-        if (!evt.persisted) {
-            // this is the first time the page has been loaded, then setup the
-            // to-be-tested scenario.
-            testRunner.queueLoad("./non-existent.html");
-            testRunner.queueBackNavigation(1);
-            testRunner.queueForwardNavigation(1);
-            testRunner.queueBackNavigation(1);
-            testRunner.queueNonLoadingScript("eval(\"" + isOkToContinue + "\")");
-        }
-    }
-
-    window.onpageshow = onPageShow;
-    </script>
-    <body>
-        <h1 id='console'/>
-    </body>
-</html>
index a024a83..3a8c5e9 100644 (file)
@@ -49,9 +49,6 @@ fast/history/window-open.html
 # EFL's LayoutTestController does not implement shadowPseudoId
 media/video-volume-slider.html
 
-# Need to add functionality to DumpRenderTree to handle error pages
-fast/history/back-forward-reset-after-error-handling.html
-
 # BUG: Captions support needed in the media engine (via GTK+)
 media/media-captions.html
 
index 6f5ef15..bf49bfa 100644 (file)
@@ -1959,9 +1959,6 @@ webkit.org/b/30620 fast/xsl/sort-locale.xml [ Failure ]
 
 webkit.org/b/53986 svg/text/caret-in-svg-text.xhtml [ Failure ]
 
-# Need to add functionality to DumpRenderTree to handle error pages
-Bug(GTK) fast/history/back-forward-reset-after-error-handling.html [ Failure ]
-
 # Paged continuousMouseScrollBy() events are not supported in GTK.
 Bug(GTK) fast/events/platform-wheelevent-paging-x-in-non-scrolling-div.html [ Failure Timeout ]
 Bug(GTK) fast/events/platform-wheelevent-paging-x-in-non-scrolling-page.html [ Failure ]
index 6cde9fd..8edce10 100644 (file)
@@ -1856,7 +1856,6 @@ fast/frames/sandboxed-iframe-navigation-allowed.html [ Failure ]
 fast/frames/valid.html [ Failure ]
 fast/gradients/background-clipped.html [ Failure ]
 fast/hidpi/image-srcset-data-srcset.html [ Failure ]
-fast/history/back-forward-reset-after-error-handling.html [ Failure ]
 fast/images/gif-large-checkerboard.html [ Failure ]
 fast/images/gray-scale-jpeg-with-color-profile.html [ Failure ]
 fast/images/icon-decoding.html [ Failure ]
index f359c90..8f08e03 100644 (file)
@@ -53,9 +53,6 @@ accessibility/children-changed-sends-notification.html
 accessibility/menu-list-sends-change-notification.html
 accessibility/multiselect-list-reports-active-option.html
 
-# Need to add functionality to DumpRenderTree to handle error pages
-fast/history/back-forward-reset-after-error-handling.html
-
 # Need to implement this in plugins code in WebKit
 plugins/reloadplugins-and-pages.html
 
index 40749fa..7825105 100644 (file)
@@ -200,9 +200,6 @@ webkit.org/b/95959 css3/device-adapt/ [ Skip ]
 fast/dom/Window/slow-unload-handler.html [ Skip ]
 fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html [ Skip ]
 
-# Need to add functionality to DumpRenderTree to handle error pages (mac as well)
-fast/history/back-forward-reset-after-error-handling.html [ Skip ]
-
 # These tests require touch support
 fast/events/touch/ [ Skip ]