Add Chrome on Android instrumentation test types to flakiness dashboard
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Jan 2013 03:29:03 +0000 (03:29 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 18 Jan 2013 03:29:03 +0000 (03:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=106964

Patch by Frank Farzan <frankf@chromium.org> on 2013-01-17
Reviewed by Ojan Vafai.

Specifically, add these test types:

 androidwebview_instrumentation_tests
 chromiumtestshell_instrumentation_tests
 contentshell_instrumentation_tests

Also, add ChromiumFYI to the list of masters.

* TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@140092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestResultServer/static-dashboards/builders.js
Tools/TestResultServer/static-dashboards/dashboard_base.js

index 4f8b656..bfe84dd 100644 (file)
@@ -1,3 +1,23 @@
+2013-01-17  Frank Farzan  <frankf@chromium.org>
+
+        Add Chrome on Android instrumentation test types to flakiness dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=106964
+
+        Reviewed by Ojan Vafai.
+
+        Specifically, add these test types:
+        
+         androidwebview_instrumentation_tests
+         chromiumtestshell_instrumentation_tests
+         contentshell_instrumentation_tests
+        
+        Also, add ChromiumFYI to the list of masters.
+
+        * TestResultServer/static-dashboards/builders.js:
+        (loadBuildersList):
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (currentBuilderGroupCategory):
+
 2013-01-17  Tim 'mithro' Ansell  <mithro@mithis.com>
 
         Fixing webkitpy's SCM unit tests.
index f971a65..5a3a2e2 100644 (file)
@@ -91,6 +91,7 @@ CHROMIUM_LINUX_BUILDER_MASTER = 'ChromiumLinux';
 CHROMIUMOS_BUILDER_MASTER = 'ChromiumChromiumOS';
 CHROMIUM_GPU_BUILDER_MASTER = 'ChromiumGPU';
 CHROMIUM_GPU_FYI_BUILDER_MASTER = 'ChromiumGPUFYI';
+CHROMIUM_FYI_BUILDER_MASTER = 'ChromiumFYI';
 CHROMIUM_PERF_AV_BUILDER_MASTER = 'ChromiumPerfAv';
 CHROMIUM_WEBKIT_BUILDER_MASTER = 'ChromiumWebkit';
 WEBKIT_BUILDER_MASTER = 'webkit.org';
@@ -235,7 +236,18 @@ function loadBuildersList(groupName, testType) {
             requestBuilderList(TEST_SHELL_TESTS_BUILDER_GROUPS, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, builderGroup, testType, isChromiumWebkitDepsTestRunner);
             break;
         }
-        break;    
+        break;
+
+    case 'androidwebview_instrumentation_tests':
+    case 'chromiumtestshell_instrumentation_tests':
+    case 'contentshell_instrumentation_tests':
+        switch(groupName) {
+        case '@DEPS FYI - chromium.org':
+            var builderGroup = new BuilderGroup(BuilderGroup.DEPS_WEBKIT);
+            requestBuilderList(CHROMIUM_INSTRUMENTATION_TESTS_BUILDER_GROUPS, CHROMIUM_FYI_BUILDER_MASTER , groupName, builderGroup, testType);
+            break;
+        }
+        break;
 
     default:
         switch(groupName) {
@@ -283,3 +295,7 @@ var CHROMIUM_GTESTS_BUILDER_GROUPS = {
     '@DEPS CrOS - chromium.org': null,
     '@ToT - chromium.org': null,
 };
+
+var CHROMIUM_INSTRUMENTATION_TESTS_BUILDER_GROUPS = {
+    '@DEPS FYI - chromium.org': null,
+};
index f31f008..1bda152 100644 (file)
@@ -146,6 +146,9 @@ var TEST_TYPES = [
     'unit_tests',
     'views_unittests',
     'webkit_unit_tests',
+    'androidwebview_instrumentation_tests',
+    'chromiumtestshell_instrumentation_tests',
+    'contentshell_instrumentation_tests',
 ];
 
 var RELOAD_REQUIRING_PARAMETERS = ['showAllRuns', 'group', 'testType'];
@@ -181,6 +184,7 @@ function handleValidHashParameterWrapper(key, value)
             function() {
               return value in LAYOUT_TESTS_BUILDER_GROUPS ||
                   value in CHROMIUM_GPU_TESTS_BUILDER_GROUPS ||
+                  value in CHROMIUM_INSTRUMENTATION_TESTS_BUILDER_GROUPS ||
                   value in CHROMIUM_GTESTS_BUILDER_GROUPS;
             });
         return true;
@@ -404,6 +408,10 @@ function currentBuilderGroupCategory()
     case 'test_shell_tests':
     case 'webkit_unit_tests':
         return TEST_SHELL_TESTS_BUILDER_GROUPS;
+    case 'androidwebview_instrumentation_tests':
+    case 'chromiumtestshell_instrumentation_tests':
+    case 'contentshell_instrumentation_tests':
+        return CHROMIUM_INSTRUMENTATION_TESTS_BUILDER_GROUPS;
     default:
         return CHROMIUM_GTESTS_BUILDER_GROUPS;
     }