LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Jun 2016 17:31:08 +0000 (17:31 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 9 Jun 2016 17:31:08 +0000 (17:31 +0000)
https://bugs.webkit.org/show_bug.cgi?id=158501

Reviewed by Darin Adler.

The order in which the transaction abort happens doesn't matter; It only matters that it happens.

Update the test to reflect this.

* storage/indexeddb/modern/handle-user-delete-expected.txt:
* storage/indexeddb/modern/resources/handle-user-delete.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/storage/indexeddb/modern/handle-user-delete-expected.txt
LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js

index 65103d8..3623e2e 100644 (file)
@@ -1,3 +1,17 @@
+2016-06-09  Brady Eidson  <beidson@apple.com>
+
+        LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
+        https://bugs.webkit.org/show_bug.cgi?id=158501
+
+        Reviewed by Darin Adler.
+        
+        The order in which the transaction abort happens doesn't matter; It only matters that it happens.
+        
+        Update the test to reflect this.
+        
+        * storage/indexeddb/modern/handle-user-delete-expected.txt:
+        * storage/indexeddb/modern/resources/handle-user-delete.js:
+
 2016-06-09  Simon Fraser  <simon.fraser@apple.com>
 
         border-radius with different width and height rendered wrong
index 146147b..c0cd0ef 100644 (file)
@@ -10,9 +10,9 @@ indexedDB.open(dbname)
 Initial upgrade needed: Old version - 0 New version - 1
 Started two spinning requests
 Requested clearAllDatabases
-Initial upgrade versionchange transaction aborted: [object DOMError]
 [PASS] Both requests hit a failure condition (Received onerror or failed to start a new request because the transaction was aborted)
 [PASS] Database received correct error.
+[PASS] Transaction aborted.
 PASS successfullyParsed is true
 
 TEST COMPLETE
index e690966..44503ee 100644 (file)
@@ -4,6 +4,7 @@ indexedDBTest(prepareDatabase);
 
 var requestErrorCount = 0;
 var databaseError = false;
+var transactionAbort = false;
 
 function done()
 {
@@ -16,7 +17,12 @@ function done()
         log("[PASS] Database received correct error.");
     else
         log("[FAIL] Database did not receive correct error.");
-        
+
+    if (transactionAbort)
+        log("[PASS] Transaction aborted.");
+    else
+        log("[FAIL] Transaction did not abort.");
+
     finishJSTest();
 }
 
@@ -27,7 +33,7 @@ function log(message)
 
 function maybeFinish()
 {
-    if (requestErrorCount == 2 && databaseError)
+    if (requestErrorCount == 2 && databaseError && transactionAbort)
         done();
 }
 
@@ -77,7 +83,8 @@ function prepareDatabase(event)
     log("Started two spinning requests")
 
     versionTransaction.onabort = function(event) {
-        log("Initial upgrade versionchange transaction aborted: " + versionTransaction.error);
+        transactionAbort = true;
+               maybeFinish();
     }
 
     versionTransaction.oncomplete = function() {