Web Inspector: console.error output broken, does not produce ObjectTree
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Mar 2015 02:36:12 +0000 (02:36 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 11 Mar 2015 02:36:12 +0000 (02:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=142554

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-10
Reviewed by Timothy Hatcher.

* UserInterface/Models/IssueMessage.js:
(WebInspector.IssueMessage):
* UserInterface/Protocol/ConsoleObserver.js:
(WebInspector.ConsoleObserver.prototype.messageAdded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@181361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Models/IssueMessage.js
Source/WebInspectorUI/UserInterface/Protocol/ConsoleObserver.js

index 681f8ee..901af52 100644 (file)
@@ -1,3 +1,15 @@
+2015-03-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: console.error output broken, does not produce ObjectTree
+        https://bugs.webkit.org/show_bug.cgi?id=142554
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/IssueMessage.js:
+        (WebInspector.IssueMessage):
+        * UserInterface/Protocol/ConsoleObserver.js:
+        (WebInspector.ConsoleObserver.prototype.messageAdded):
+
 2015-03-10  Saam Barati  <saambarati1@gmail.com>
 
         Web Inspector: Destructuring function parameters should show type information
index 003d7e4..8e3eb86 100644 (file)
@@ -45,6 +45,8 @@ WebInspector.IssueMessage = function(source, level, text, url, lineNumber, colum
     if (typeof columnNumber === "number" && columnNumber >= 0)
         this._columnNumber = columnNumber;
 
+    // FIXME: <https://webkit.org/b/142553> Web Inspector: Merge IssueMessage/ConsoleMessage - both attempt to modify the Console Messages parameter independently
+
     if (parameters && parameters !== "undefined") {
         this._parameters = [];
         for (var i = 0; i < parameters.length; ++i) {
index 7d4953e..764e799 100644 (file)
@@ -38,8 +38,10 @@ WebInspector.ConsoleObserver.prototype = {
         if (message.type === "assert" && !message.text)
             message.text = WebInspector.UIString("Assertion");
 
-        if (message.level === "warning" || message.level === "error")
-            WebInspector.issueManager.issueWasAdded(message.source, message.level, message.text, message.url, message.line, message.column || 0, message.parameters);
+        if (message.level === "warning" || message.level === "error") {
+            // FIXME: <https://webkit.org/b/142553> Web Inspector: Merge IssueMessage/ConsoleMessage - both attempt to modify the Console Messages parameter independently
+            WebInspector.issueManager.issueWasAdded(message.source, message.level, message.text, message.url, message.line, message.column || 0);
+        }
 
         if (message.source === "console-api" && message.type === "clear")
             return;