run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done...
authorddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Sep 2019 17:50:26 +0000 (17:50 +0000)
committerddkilzer@apple.com <ddkilzer@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 17 Sep 2019 17:50:26 +0000 (17:50 +0000)
<https://webkit.org/b/201873>

Reviewed by Jonathan Bedard.

* Scripts/webkitpy/port/driver.py:
(Driver.run_test): Call self.do_post_tests_work() when a test
shard has completed, but didn't crash or time out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/driver.py

index 577faab..b5c38a6 100644 (file)
@@ -1,3 +1,14 @@
+2019-09-17  David Kilzer  <ddkilzer@apple.com>
+
+        run-webkit-tests: Driver.do_post_tests_work() is never called when `stop_when_done` is true in Driver.run_test()
+        <https://webkit.org/b/201873>
+
+        Reviewed by Jonathan Bedard.
+
+        * Scripts/webkitpy/port/driver.py:
+        (Driver.run_test): Call self.do_post_tests_work() when a test
+        shard has completed, but didn't crash or time out.
+
 2019-09-17  Chris Dumez  <cdumez@apple.com>
 
         REGRESSION (r249923): ASSERTION FAILED: sessionID == WebProcess::singleton().sessionID() in WebCore::SWClientConnection *WebKit::WebServiceWorkerProvider::existingServiceWorkerConnectionForSession(PAL::SessionID)
index 1b1d2dc..2a59838 100644 (file)
@@ -221,6 +221,8 @@ class Driver(object):
         pid = self._server_process.pid()
 
         if stop_when_done or crashed or timed_out:
+            if stop_when_done and not (crashed or timed_out):
+                self.do_post_tests_work()
             # We call stop() even if we crashed or timed out in order to get any remaining stdout/stderr output.
             # In the timeout case, we kill the hung process as well.
             out, err = self._server_process.stop(self._port.driver_stop_timeout() if stop_when_done else 0.0)