REGRESSION(r176687): Caused webkit2 test assertion failure crashes in WebKit::WebPage...
authormitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Dec 2014 19:08:53 +0000 (19:08 +0000)
committermitz@apple.com <mitz@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 3 Dec 2014 19:08:53 +0000 (19:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=139224

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting): Wait for the UI process to start dragging if
needed before handling the event.

LayoutTests:

* platform/wk2/TestExpectations: Unskip the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/wk2/TestExpectations
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/WebPage.cpp

index 2ef6661..704d3a2 100644 (file)
@@ -1,3 +1,12 @@
+2014-12-03  Dan Bernstein  <mitz@apple.com>
+
+        REGRESSION(r176687): Caused webkit2 test assertion failure crashes in WebKit::WebPage::willStartDrag()
+        https://bugs.webkit.org/show_bug.cgi?id=139224
+
+        Reviewed by Alexey Proskuryakov.
+
+        * platform/wk2/TestExpectations: Unskip the tests.
+
 2014-12-03  Mark Lam  <mark.lam@apple.com>
 
         Gardening: updating some tests as skips instead of crashes.
index d7909c0..80c6548 100644 (file)
@@ -223,15 +223,6 @@ webkit.org/b/127683 http/tests/navigation/new-window-redirect-history.html [ Ski
 
 webkit.org/b/132297 svg/custom/bug79798.html [ Skip ]
 
-# These tests started crashing with assertion failures only on debug builds after r176687:
-webkit.org/b/139224 [ Debug ] fast/events/clear-drag-state.html  [ Skip ]
-webkit.org/b/139224 [ Debug ] fast/css/user-drag-none.html  [ Skip ]
-webkit.org/b/139224 [ Debug ] editing/pasteboard/dataTransfer-setData-getData.html [ Skip ]
-webkit.org/b/139224 [ Debug ] editing/pasteboard/drop-text-events-sideeffect-crash.html [ Skip ]
-webkit.org/b/139224 [ Debug ] editing/pasteboard/drag-drop-iframe-refresh-crash.html [ Skip ]
-webkit.org/b/139224 [ Debug ] editing/pasteboard/drop-text-events-sideeffect.html [ Skip ]
-webkit.org/b/139224 [ Debug ] editing/selection/user-drag-element-and-user-select-none.html [ Skip ]
-
 ### END OF (1) Classified failures with bug reports
 ########################################
 
index b6201e8..a4ec6de 100644 (file)
@@ -1,3 +1,14 @@
+2014-12-03  Dan Bernstein  <mitz@apple.com>
+
+        REGRESSION(r176687): Caused webkit2 test assertion failure crashes in WebKit::WebPage::willStartDrag()
+        https://bugs.webkit.org/show_bug.cgi?id=139224
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::mouseEventSyncForTesting): Wait for the UI process to start dragging if
+        needed before handling the event.
+
 2014-12-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 
         [GTK] outdated comment
index dcce1cd..39e935a 100644 (file)
@@ -1955,6 +1955,11 @@ void WebPage::mouseEvent(const WebMouseEvent& mouseEvent)
 
 void WebPage::mouseEventSyncForTesting(const WebMouseEvent& mouseEvent, bool& handled)
 {
+#if ENABLE(DRAG_SUPPORT)
+    if (m_isStartingDrag)
+        messageSenderConnection()->waitForAndDispatchImmediately<Messages::WebPage::DidStartDrag>(messageSenderDestinationID(), std::chrono::seconds(60));
+#endif
+
     handled = false;
 #if !PLATFORM(IOS)
     if (!handled && m_headerBanner)