2010-05-25 Kent Tamura <tkent@chromium.org>
authordglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 May 2010 17:59:36 +0000 (17:59 +0000)
committerdglazkov@chromium.org <dglazkov@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 May 2010 17:59:36 +0000 (17:59 +0000)
        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Enable 3D_CANVAS, FILTERS, METER_TAG and PROGRESS_TAG
        https://bugs.webkit.org/show_bug.cgi?id=39652

        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::paintMeter): Fix narrowPrecisionToFloat() usage.
2010-05-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [DRT/Chromium] Enable 3D_CANVAS, FILTERS, METER_TAG and PROGRESS_TAG
        https://bugs.webkit.org/show_bug.cgi?id=39652

        3D_CANVAS and FILTERS have been enabled for Chromium tree
        build. They fix dozens of unexpected test results in a case of
        upstreaming build.
        Enable METER_TAG and PROGRESS_TAG too because they will be enabled
        in Chromium tree in the near future.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/rendering/RenderTheme.cpp
WebKit/chromium/ChangeLog
WebKit/chromium/features.gypi

index d006fb8..797cf10 100644 (file)
@@ -1,3 +1,13 @@
+2010-05-25  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [DRT/Chromium] Enable 3D_CANVAS, FILTERS, METER_TAG and PROGRESS_TAG
+        https://bugs.webkit.org/show_bug.cgi?id=39652
+
+        * rendering/RenderTheme.cpp:
+        (WebCore::RenderTheme::paintMeter): Fix narrowPrecisionToFloat() usage.
+
 2010-05-25  Darin Adler  <darin@apple.com>
 
         Sort ".exp" files with the sort tool.
index 445e637..49a954a 100644 (file)
@@ -933,7 +933,7 @@ bool RenderTheme::paintMeter(RenderObject* renderObject, const RenderObject::Pai
         // left to right horizontal gauge
         double scale = innerRect.width() / (max - min);
         valueRect.setLocation(innerRect.location());
-        valueRect.setSize(FloatSize(narrowPrecisionToFloat((value - min)) * scale, innerRect.height()));
+        valueRect.setSize(FloatSize(narrowPrecisionToFloat((value - min) * scale), innerRect.height()));
     }
     if (!valueRect.isEmpty())
         paintInfo.context->fillRect(valueRect, Color::black, style->colorSpace());
index 8c08538..8593698 100644 (file)
@@ -1,3 +1,18 @@
+2010-05-25  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [DRT/Chromium] Enable 3D_CANVAS, FILTERS, METER_TAG and PROGRESS_TAG
+        https://bugs.webkit.org/show_bug.cgi?id=39652
+
+        3D_CANVAS and FILTERS have been enabled for Chromium tree
+        build. They fix dozens of unexpected test results in a case of
+        upstreaming build.
+        Enable METER_TAG and PROGRESS_TAG too because they will be enabled
+        in Chromium tree in the near future.
+
+        * features.gypi:
+
 2010-05-25  Vangelis Kokkevis  <vangelis@chromium.org>
 
         Reviewed by Darin Fisher.
index 77baf66..c7d40cf 100644 (file)
@@ -39,7 +39,7 @@
       # chromium build, overrides this list with its own values. See
       # features_override.gypi inline documentation for more details.
       'feature_defines%': [
-        'ENABLE_3D_CANVAS=0',
+        'ENABLE_3D_CANVAS=1',
         'ENABLE_BLOB_SLICE=1',
         'ENABLE_CHANNEL_MESSAGING=1',
         'ENABLE_DASHBOARD_SUPPORT=0',
         'ENABLE_DOM_STORAGE=1',
         'ENABLE_FILE_READER=1',
         'ENABLE_FILE_WRITER=0',
+        'ENABLE_FILTERS=1',
         'ENABLE_GEOLOCATION=1',
         'ENABLE_ICONDATABASE=0',
         'ENABLE_INDEXED_DATABASE=1',
         'ENABLE_JAVASCRIPT_DEBUGGER=1',
         'ENABLE_JSC_MULTIPLE_THREADS=0',
+        'ENABLE_METER_TAG=1',
         'ENABLE_NOTIFICATIONS=1',
         'ENABLE_OFFLINE_WEB_APPLICATIONS=1',
         'ENABLE_OPENTYPE_SANITIZER=1',
         'ENABLE_ORIENTATION_EVENTS=0',
+        'ENABLE_PROGRESS_TAG=1',
         'ENABLE_RUBY=1',
         'ENABLE_SANDBOX=1',
         'ENABLE_SHARED_WORKERS=1',