Move Ad Click Attribution from internal feature to experimental feature
authorwilander@apple.com <wilander@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Apr 2019 04:16:30 +0000 (04:16 +0000)
committerwilander@apple.com <wilander@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 24 Apr 2019 04:16:30 +0000 (04:16 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197218
<rdar://problem/47651691>

Reviewed by Brent Fulgham.

Source/WebKit:

* Shared/WebPreferences.yaml:

Tools:

* DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):

LayoutTests:

This patch removes the TestRunner instruction for turning on the internal
feature.

* http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
* http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
* http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
* http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
* http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
* http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
* http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
* http/tests/adClickAttribution/send-attribution-conversion-request.html:
* http/tests/adClickAttribution/store-ad-click-attribution.html:
* http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
* http/tests/contentextensions/block-ad-click-attribution.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 files changed:
LayoutTests/ChangeLog
LayoutTests/http/tests/adClickAttribution/anchor-tag-attributes-validation.html
LayoutTests/http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html
LayoutTests/http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html
LayoutTests/http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html
LayoutTests/http/tests/adClickAttribution/second-conversion-with-higher-priority.html
LayoutTests/http/tests/adClickAttribution/second-conversion-with-lower-priority.html
LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html
LayoutTests/http/tests/adClickAttribution/store-ad-click-attribution.html
LayoutTests/http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html
LayoutTests/http/tests/contentextensions/block-ad-click-attribution.html
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Tools/ChangeLog
Tools/DumpRenderTree/TestOptions.cpp

index 75e5e06..a27c3b2 100644 (file)
@@ -1,5 +1,28 @@
 2019-04-23  John Wilander  <wilander@apple.com>
 
+        Move Ad Click Attribution from internal feature to experimental feature
+        https://bugs.webkit.org/show_bug.cgi?id=197218
+        <rdar://problem/47651691>
+
+        Reviewed by Brent Fulgham.
+
+        This patch removes the TestRunner instruction for turning on the internal
+        feature.
+
+        * http/tests/adClickAttribution/anchor-tag-attributes-validation.html:
+        * http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority.html:
+        * http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
+        * http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html:
+        * http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html:
+        * http/tests/adClickAttribution/second-conversion-with-higher-priority.html:
+        * http/tests/adClickAttribution/second-conversion-with-lower-priority.html:
+        * http/tests/adClickAttribution/send-attribution-conversion-request.html:
+        * http/tests/adClickAttribution/store-ad-click-attribution.html:
+        * http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
+        * http/tests/contentextensions/block-ad-click-attribution.html:
+
+2019-04-23  John Wilander  <wilander@apple.com>
+
         Remove Ad Click Attribution data when removing website data
         https://bugs.webkit.org/show_bug.cgi?id=197215
         <rdar://problem/47668988>
index 3b60239..8324309 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true, internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index fb174b1..8a0b2d8 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index c2f5fff..d6c97dc 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index dd383ed..37e2a0c 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index 7e81a97..8a3572d 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index f59e44b..edff592 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index d8a914a..acff96a 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index 437577c..98fcbfa 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index c7146d0..3df76b0 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index f575e51..28fea7b 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index a166bad..414cce8 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true internal:AdClickAttributionEnabled=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true ] -->
 <html lang="en">
 <head>
     <meta charset="UTF-8">
index 92cc8c1..6b7bb25 100644 (file)
@@ -1,3 +1,13 @@
+2019-04-23  John Wilander  <wilander@apple.com>
+
+        Move Ad Click Attribution from internal feature to experimental feature
+        https://bugs.webkit.org/show_bug.cgi?id=197218
+        <rdar://problem/47651691>
+
+        Reviewed by Brent Fulgham.
+
+        * Shared/WebPreferences.yaml:
+
 2019-04-23  Keith Rollin  <krollin@apple.com>
 
         Add Xcode version check for Header post-processing scripts
index a01fcac..e42d923 100644 (file)
@@ -1404,6 +1404,14 @@ ResizeObserverEnabled:
   category: experimental
   condition: ENABLE(RESIZE_OBSERVER)
 
+AdClickAttributionEnabled:
+    type: bool
+    defaultValue: false
+    humanReadableName: "Ad Click Attribution"
+    humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations"
+    webcoreBinding: RuntimeEnabledFeatures
+    category: experimental
+
 # For internal features:
 # The type should be boolean.
 # You must provide a humanReadableName and humanReadableDescription for all debug features. They
@@ -1602,14 +1610,6 @@ CSSLogicalEnabled:
   webcoreBinding: RuntimeEnabledFeatures
   category: internal
 
-AdClickAttributionEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Ad Click Attribution"
-  humanReadableDescription: "Enable Ad Click Attribution for Cross-Site Link Navigations"
-  webcoreBinding: RuntimeEnabledFeatures
-  category: internal
-
 DOMPasteAccessRequestsEnabled:
   type: bool
   defaultValue: DEFAULT_DOM_PASTE_ACCESS_REQUESTS_ENABLED
index 8116d58..498a075 100644 (file)
@@ -1,3 +1,14 @@
+2019-04-23  John Wilander  <wilander@apple.com>
+
+        Move Ad Click Attribution from internal feature to experimental feature
+        https://bugs.webkit.org/show_bug.cgi?id=197218
+        <rdar://problem/47651691>
+
+        Reviewed by Brent Fulgham.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (TestOptions::TestOptions):
+
 2019-04-23  Andy Estes  <aestes@apple.com>
 
         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
index 77a4aff..0c93c80 100644 (file)
@@ -109,7 +109,7 @@ TestOptions::TestOptions(const std::string& pathOrURL, const std::string& absolu
             enableWebGPU = parseBooleanTestHeaderValue(value);
         else if (key == "internal:CSSLogicalEnabled")
             enableCSSLogical = parseBooleanTestHeaderValue(value);
-        else if (key == "internal:AdClickAttributionEnabled")
+        else if (key == "experimental:AdClickAttributionEnabled")
             adClickAttributionEnabled = parseBooleanTestHeaderValue(value);
         else if (key == "experimental:ResizeObserverEnabled")
             enableResizeObserver = parseBooleanTestHeaderValue(value);