2011-11-08 Nikolas Zimmermann <nzimmermann@rim.com>
authorzimmermann@webkit.org <zimmermann@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 8 Nov 2011 14:19:40 +0000 (14:19 +0000)
committerzimmermann@webkit.org <zimmermann@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 8 Nov 2011 14:19:40 +0000 (14:19 +0000)
        [Chromium] SVG test failures after r99539
        https://bugs.webkit.org/show_bug.cgi?id=71793

        Reviewed by Zoltan Herczeg.

        It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
        That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
        That cries for problems if the machine is slow or loaded.

        I left the 400ms sample snapshot for now, we can still relax it later.

        * fast/backgrounds/resources/animated-rect-relative-size.svg:
        * svg/as-background-image/resources/animated-rect-relative-size.svg:
        * svg/as-image/resources/animated-rect-fixed-size.svg:
        * svg/as-image/resources/animated-rect-relative-size.svg:
        * svg/as-image/resources/animated-rect-same-image.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/backgrounds/resources/animated-rect-relative-size.svg
LayoutTests/svg/as-background-image/resources/animated-rect-relative-size.svg
LayoutTests/svg/as-image/resources/animated-rect-fixed-size.svg
LayoutTests/svg/as-image/resources/animated-rect-relative-size.svg
LayoutTests/svg/as-image/resources/animated-rect-same-image.svg

index 7013e55..be45426 100644 (file)
@@ -1,3 +1,22 @@
+2011-11-08  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        [Chromium] SVG test failures after r99539
+        https://bugs.webkit.org/show_bug.cgi?id=71793
+
+        Reviewed by Zoltan Herczeg.
+
+        It turns out that some of these tests are flakey. Replace <animate> elements with <set>.
+        That still tests repaint, but there's no need to run a 100ms animation, and then sample it after 400ms.
+        That cries for problems if the machine is slow or loaded.
+
+        I left the 400ms sample snapshot for now, we can still relax it later.
+
+        * fast/backgrounds/resources/animated-rect-relative-size.svg:
+        * svg/as-background-image/resources/animated-rect-relative-size.svg:
+        * svg/as-image/resources/animated-rect-fixed-size.svg:
+        * svg/as-image/resources/animated-rect-relative-size.svg:
+        * svg/as-image/resources/animated-rect-same-image.svg:
+
 2011-11-08  Yuta Kitamura  <yutak@chromium.org>
 
         [Chromium] Unreviewed, add three more CG-only failures.
index 0831eff..4a51251 100644 (file)
@@ -21,7 +21,7 @@
             <text font-size="36" x="20" y="140">6</text>
             <line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
             <rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
-              <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+              <set attributeName="width" to="30" begin="0s" fill="freeze"/> 
             </rect>
          </g>
       </g>
index 0831eff..4a51251 100644 (file)
@@ -21,7 +21,7 @@
             <text font-size="36" x="20" y="140">6</text>
             <line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
             <rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
-              <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+              <set attributeName="width" to="30" begin="0s" fill="freeze"/> 
             </rect>
          </g>
       </g>
index a1f12f2..fd06728 100644 (file)
@@ -21,7 +21,7 @@
             <text font-size="36" x="20" y="140">6</text>
             <line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
             <rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
-               <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+               <set attributeName="width" to="30" begin="0s" fill="freeze"/> 
             </rect>
          </g>
       </g>
index 0831eff..4a51251 100644 (file)
@@ -21,7 +21,7 @@
             <text font-size="36" x="20" y="140">6</text>
             <line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
             <rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
-              <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+              <set attributeName="width" to="30" begin="0s" fill="freeze"/> 
             </rect>
          </g>
       </g>
index a1f12f2..fd06728 100644 (file)
@@ -21,7 +21,7 @@
             <text font-size="36" x="20" y="140">6</text>
             <line x1="30" y1="0" x2="30" y2="100" fill="none" stroke="#880000" />
             <rect x="0" y="0" width="300" height="80" fill="#44AAFF" stroke="#880088" stroke-width="4" >
-               <animate attributeName="width" calcMode="discrete" values="300;30" keyTimes="0;.6" begin="0s" dur="100ms" fill="freeze"/>
+               <set attributeName="width" to="30" begin="0s" fill="freeze"/> 
             </rect>
          </g>
       </g>