Log the error if VideoProcessing library cannot be dlopen
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Apr 2019 16:52:02 +0000 (16:52 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Apr 2019 16:52:02 +0000 (16:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196609

Reviewed by Eric Carlson.

* Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:
(webrtc::initVideoProcessingVPModuleInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/ThirdParty/libwebrtc/ChangeLog
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp

index bf8a168..0ab89a2 100644 (file)
@@ -1,3 +1,13 @@
+2019-04-04  Youenn Fablet  <youenn@apple.com>
+
+        Log the error if VideoProcessing library cannot be dlopen
+        https://bugs.webkit.org/show_bug.cgi?id=196609
+
+        Reviewed by Eric Carlson.
+
+        * Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.cpp:
+        (webrtc::initVideoProcessingVPModuleInitialize):
+
 2019-04-03  Youenn Fablet  <youenn@apple.com>
 
         Add logging and ASSERTs to investigate issue with VPModuleInitialize
index 9b12be6..d6390e6 100644 (file)
@@ -73,7 +73,8 @@ static void initVideoProcessingVPModuleInitialize();
 void (*softLinkVideoProcessingVPModuleInitialize) () = initVideoProcessingVPModuleInitialize;
 static void initVideoProcessingVPModuleInitialize()
 {
-    auto* library = VideoProcessingLibrary();
+
+    auto* library = dlopen("/System/Library/PrivateFrameworks/VideoProcessing.framework/VideoProcessing", RTLD_NOW);
     if (!library)
         fprintf(stderr, "Cannot find VideoProcessingLibrary: %s\n", dlerror());
     softLinkVideoProcessingVPModuleInitialize = (void (*)()) dlsym(library, "VPModuleInitialize");