Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Mar 2017 22:14:49 +0000 (22:14 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 28 Mar 2017 22:14:49 +0000 (22:14 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170193

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
Fixed the order of arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js
Tools/ChangeLog

index 4b5ce4e..28bdb8c 100644 (file)
@@ -324,7 +324,7 @@ test("_presentPopoverForJavaScriptCoreTestRegressions including loading", functi
     iteration.javaScriptCoreTestResults = new MockBuildbotTestResults();
 
     var view = new BuildbotQueueView();
-    view._presentPopoverForJavaScriptCoreTestRegressions(element, popover, iteration, "jscore-test");
+    view._presentPopoverForJavaScriptCoreTestRegressions("jscore-test", element, popover, iteration);
 
     JSON.load("resources/test-jsc-results.json", function(data)
     {
@@ -368,7 +368,7 @@ test("_presentPopoverForJavaScriptCoreTestRegressions already loaded", function(
     iteration.javaScriptCoreTestResults = {"regressions": ["uno", "dos", "tres"]};
 
     var view = new BuildbotQueueView();
-    view._presentPopoverForJavaScriptCoreTestRegressions(element, popover, iteration, "jscore-test");
+    view._presentPopoverForJavaScriptCoreTestRegressions("jscore-test", element, popover, iteration);
 
     var numChildrenInEmptyPopoverContent = 2;
     strictEqual(popover._content.childNodes.length - numChildrenInEmptyPopoverContent,
index ace8cc3..3c25edb 100644 (file)
@@ -1,5 +1,15 @@
 2017-03-28  Aakash Jain  <aakash_jain@apple.com>
 
+        Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
+        https://bugs.webkit.org/show_bug.cgi?id=170193
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
+        Fixed the order of arguments.
+
+2017-03-28  Aakash Jain  <aakash_jain@apple.com>
+
         Dashboard tests fails to fetch the revision from commits
         https://bugs.webkit.org/show_bug.cgi?id=170191