Rebaseline and enable media/modern-media-controls/airplay-support
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Jun 2017 16:29:20 +0000 (16:29 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Jun 2017 16:29:20 +0000 (16:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=172980
Source/WebCore:

Reviewed by Eric Carlson.

Fixing a small issue in the modern media controls code which would yield
an error when manually creating a MediaController without a MediaControlsHost.

* Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.get isAudio):

LayoutTests:

<rdar://problem/32589074>

Reviewed by Eric Carlson.

The test passes as-is on macOS, but needs to be skipped on iOS since we can't test AirPlay.

* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/mac/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/Modules/modern-media-controls/media/media-controller.js

index 035ed6a..0002c43 100644 (file)
@@ -1,5 +1,18 @@
 2017-06-06  Antoine Quint  <graouts@apple.com>
 
+        Rebaseline and enable media/modern-media-controls/airplay-support
+        https://bugs.webkit.org/show_bug.cgi?id=172980
+        <rdar://problem/32589074>
+
+        Reviewed by Eric Carlson.
+
+        The test passes as-is on macOS, but needs to be skipped on iOS since we can't test AirPlay.
+
+        * platform/ios-simulator/TestExpectations:
+        * platform/mac/TestExpectations:
+
+2017-06-06  Antoine Quint  <graouts@apple.com>
+
         Rebaseline and enable media/modern-media-controls/airplay-placard
         https://bugs.webkit.org/show_bug.cgi?id=172977
         <rdar://problem/32588681>
index b98eb68..9ba27fa 100644 (file)
@@ -60,4 +60,7 @@ media/modern-media-controls/airplay-placard [ Pass ]
 media/modern-media-controls/audio/audio-controls-styles.html [ Pass ]
 media/modern-media-controls/audio/audio-controls-metrics.html [ Pass ]
 
+# AirPlay cannot be tested on iOS
+webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
+
 webkit.org/b/172965 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Failure ]
index b25feda..e94a709 100644 (file)
@@ -1551,6 +1551,7 @@ webkit.org/b/172737 fast/text/accessibility-bold-system-font-2.html [ ImageOnlyF
 # As a result, a host of tests need to be updated and being turned on selectively here.
 media/modern-media-controls/airplay-button [ Pass ]
 media/modern-media-controls/airplay-placard [ Pass ]
+media/modern-media-controls/airplay-support [ Pass ]
 media/modern-media-controls/audio/audio-controls-metrics.html [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
index 9b1e08a..97ebba4 100644 (file)
@@ -1,5 +1,18 @@
 2017-06-06  Antoine Quint  <graouts@apple.com>
 
+        Rebaseline and enable media/modern-media-controls/airplay-support
+        https://bugs.webkit.org/show_bug.cgi?id=172980
+
+        Reviewed by Eric Carlson.
+
+        Fixing a small issue in the modern media controls code which would yield
+        an error when manually creating a MediaController without a MediaControlsHost.
+
+        * Modules/modern-media-controls/media/media-controller.js:
+        (MediaController.prototype.get isAudio):
+
+2017-06-06  Antoine Quint  <graouts@apple.com>
+
         Update modern media controls testing utilities
         https://bugs.webkit.org/show_bug.cgi?id=172976
         <rdar://problem/32588432>
index 1d3bdc5..1495201 100644 (file)
@@ -65,7 +65,7 @@ class MediaController
         if (this.media instanceof HTMLAudioElement)
             return true;
 
-        if (!this.host.isInMediaDocument && this.media instanceof HTMLVideoElement)
+        if (this.host && !this.host.isInMediaDocument && this.media instanceof HTMLVideoElement)
             return false;
 
         if (this.media.readyState < HTMLMediaElement.HAVE_METADATA)