Fix flaky test fast/eventsource/eventsource-url-attribute.html
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Mar 2012 04:25:16 +0000 (04:25 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 27 Mar 2012 04:25:16 +0000 (04:25 +0000)
https://bugs.webkit.org/show_bug.cgi?id=82257

Patch by Pablo Flouret <pablof@motorola.com> on 2012-03-26
Reviewed by Ryosuke Niwa.

The test used http://localhost, chosen as a semi-random url, but since
it doesn't return a text/event-stream mime-type sometimes a console
warning would appear. Moved the test to the http folder and changed it
to use a resource with the correct mime-type.

* http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
* http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/eventsource/eventsource-url-attribute-expected.txt [moved from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt with 58% similarity]
LayoutTests/http/tests/eventsource/eventsource-url-attribute.html [moved from LayoutTests/fast/eventsource/eventsource-url-attribute.html with 63% similarity]

index 29564e0..ca9211f 100644 (file)
@@ -1,3 +1,18 @@
+2012-03-26  Pablo Flouret  <pablof@motorola.com>
+
+        Fix flaky test fast/eventsource/eventsource-url-attribute.html
+        https://bugs.webkit.org/show_bug.cgi?id=82257
+
+        Reviewed by Ryosuke Niwa.
+
+        The test used http://localhost, chosen as a semi-random url, but since
+        it doesn't return a text/event-stream mime-type sometimes a console
+        warning would appear. Moved the test to the http folder and changed it
+        to use a resource with the correct mime-type.
+
+        * http/tests/eventsource/eventsource-url-attribute-expected.txt: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute-expected.txt.
+        * http/tests/eventsource/eventsource-url-attribute.html: Renamed from LayoutTests/fast/eventsource/eventsource-url-attribute.html.
+
 2012-03-26  David Grogan  <dgrogan@chromium.org>
 
         Extract logic of indexeddb html layout tests into js files that can
@@ -3,8 +3,8 @@ Both .URL and .url should work (for compatibility reasons).
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS source.URL is "http://localhost/"
-PASS source.url is "http://localhost/"
+PASS source.URL is "http://127.0.0.1:8000/eventsource/resources/event-stream.php"
+PASS source.url is "http://127.0.0.1:8000/eventsource/resources/event-stream.php"
 PASS source.URL === source.url is true
 PASS successfullyParsed is true
 
@@ -2,14 +2,14 @@
 <html>
 <head>
 <meta charset="utf-8">
-<script src="../js/resources/js-test-pre.js"></script>
+<script src="../../js-test-resources/js-test-pre.js"></script>
 </head>
 <body>
 <script>
 
 description("Both .URL and .url should work (for compatibility reasons).");
 
-var url = "http://localhost/";
+var url = "http://127.0.0.1:8000/eventsource/resources/event-stream.php";
 var source = new EventSource(url);
 
 shouldBeEqualToString("source.URL", url);
@@ -17,6 +17,6 @@ shouldBeEqualToString("source.url", url);
 shouldBeTrue("source.URL === source.url");
 
 </script>
-<script src="../js/resources/js-test-post.js"></script>
+<script src="../../js-test-resources/js-test-post.js"></script>
 </body>
 </html>