REGRESSION: fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Aug 2019 19:21:32 +0000 (19:21 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 23 Aug 2019 19:21:32 +0000 (19:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=201075
<rdar://problem/54491246>

Patch by Antoine Quint <graouts@apple.com> on 2019-08-23
Reviewed by Daniel Bates.

This test was written very early on in the process of implementing Pointer Events and assumed events would keep
firing when scrolling occured. We need to add "touch-action: none" to ensure we get pointermove and pointerup
events. We also need to ensure that the interaction occurs over content otherwise events won't fire. Finally, we
pretty up the test a bit.

* fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt:
* fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt
LayoutTests/fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html

index f93f38a..64e5dbf 100644 (file)
@@ -1,3 +1,19 @@
+2019-08-23  Antoine Quint  <graouts@apple.com>
+
+        REGRESSION: fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=201075
+        <rdar://problem/54491246>
+
+        Reviewed by Daniel Bates.
+
+        This test was written very early on in the process of implementing Pointer Events and assumed events would keep
+        firing when scrolling occured. We need to add "touch-action: none" to ensure we get pointermove and pointerup
+        events. We also need to ensure that the interaction occurs over content otherwise events won't fire. Finally, we
+        pretty up the test a bit.
+
+        * fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup-expected.txt:
+        * fast/events/pointer/ios/drag-gives-pointerdown-pointermove-pointerup.html:
+
 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
 
         [WebAuthn] Support NFC authenticators for iOS
index 6981c91..11670b9 100644 (file)
@@ -5,7 +5,6 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 
     pointerdown fired.
-Remove this when bug 19133 is fixed.
 At least one pointermove was fired.
 pointerup fired.
 PASS successfullyParsed is true
index 9c5d235..321fb6b 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ experimental:PointerEventsEnabled=true ] -->
+<!DOCTYPE html>
 <html>
 <head>
     <script src="../../../../resources/js-test-pre.js"></script>
@@ -6,6 +6,7 @@
     <style>
         body {
             margin: none;
+            touch-action: none;
         }
     </style>
     <meta name="viewport" content="initial-scale=1">
 
         function runTest()
         {
-            // FIXME: At the moment a touch listener is required due
-            // to the way pointer events are dispatched.
-            // https://bugs.webkit.org/show_bug.cgi?id=191333
-            window.addEventListener("touchstart", (event) => {
-                debug("Remove this when bug 19133 is fixed.");
-            });
-
-            window.addEventListener("pointerdown", (event) => {
-                debug("pointerdown fired.");
-            });
+            window.addEventListener("pointerdown", event => debug("pointerdown fired."));
 
-            seenMove = false;
-            window.addEventListener("pointermove", (event) => {
+            let seenMove = false;
+            window.addEventListener("pointermove", event => {
                 if (!seenMove)
                     debug("At least one pointermove was fired.");
                 seenMove = true;
             });
 
-            window.addEventListener("pointerup", (event) => {
+            window.addEventListener("pointerup", event => {
                 debug("pointerup fired.");
                 finishJSTest();
             });
 
-            if (window.testRunner) {
-                touchAndDragFromPointToPoint(50, 200, 60, 210).then(() => {
-                    liftUpAtPoint(60, 210);
-                });
-            }
+            if (window.testRunner)
+                touchAndDragFromPointToPoint(50, 50, 40, 40).then(() => liftUpAtPoint(40, 40));
         }
 
         window.addEventListener("load", runTest, false);