Remove some non-functional elements from the Scripts panel
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 May 2008 22:48:28 +0000 (22:48 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 May 2008 22:48:28 +0000 (22:48 +0000)
so they don't confuse users why they aren't working.

Reviewed by Adam Roben.

* page/inspector/ScriptsPanel.js: Removes the back/forward buttons
and the function menu.
* page/inspector/inspector.css: Make the files menu wider since there
is more room now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/inspector/ScriptsPanel.js
WebCore/page/inspector/inspector.css

index 36d0f6c..173d6cd 100644 (file)
@@ -1,5 +1,17 @@
 2008-05-22  Timothy Hatcher  <timothy@apple.com>
 
+        Remove some non-functional elements from the Scripts panel
+        so they don't confuse users why they aren't working.
+
+        Reviewed by Adam Roben.
+
+        * page/inspector/ScriptsPanel.js: Removes the back/forward buttons
+        and the function menu.
+        * page/inspector/inspector.css: Make the files menu wider since there
+        is more room now.
+
+2008-05-22  Timothy Hatcher  <timothy@apple.com>
+
         <rdar://problem/5956403> Update the Develop menu to match the new Inspector items
 
         Reviewed by Adam Roben.
index 7367d6c..efbd125 100644 (file)
@@ -40,7 +40,9 @@ WebInspector.ScriptsPanel = function()
     this.backButton.title = WebInspector.UIString("Show the previous script resource.");
     this.backButton.disabled = true;
     this.backButton.appendChild(document.createElement("img"));
-    this.topStatusBar.appendChild(this.backButton);
+
+    // FIXME: append the back button element to the top status bar when it is implemented.
+    // this.topStatusBar.appendChild(this.backButton);
 
     this.forwardButton = document.createElement("button");
     this.forwardButton.className = "status-bar-item";
@@ -48,7 +50,9 @@ WebInspector.ScriptsPanel = function()
     this.forwardButton.title = WebInspector.UIString("Show the next script resource.");
     this.forwardButton.disabled = true;
     this.forwardButton.appendChild(document.createElement("img"));
-    this.topStatusBar.appendChild(this.forwardButton);
+
+    // FIXME: append the forward button element to the top status bar when it is implemented.
+    // this.topStatusBar.appendChild(this.forwardButton);
 
     this.filesSelectElement = document.createElement("select");
     this.filesSelectElement.className = "status-bar-item";
@@ -59,7 +63,9 @@ WebInspector.ScriptsPanel = function()
     this.functionsSelectElement = document.createElement("select");
     this.functionsSelectElement.className = "status-bar-item";
     this.functionsSelectElement.id = "scripts-functions";
-    this.topStatusBar.appendChild(this.functionsSelectElement);
+
+    // FIXME: append the functions select element to the top status bar when it is implemented.
+    // this.topStatusBar.appendChild(this.functionsSelectElement);
 
     this.sidebarButtonsElement = document.createElement("div");
     this.sidebarButtonsElement.id = "scripts-sidebar-buttons";
@@ -128,6 +134,9 @@ WebInspector.ScriptsPanel = function()
     for (var pane in this.sidebarPanes)
         this.sidebarElement.appendChild(this.sidebarPanes[pane].element);
 
+    // FIXME: remove the following line of code when the Breakpoints pane has content.
+    this.sidebarElement.removeChild(this.sidebarPanes.breakpoints.element);
+
     this.sidebarPanes.callstack.expanded = true;
     this.sidebarPanes.callstack.addEventListener("call frame selected", this._callFrameSelected, this);
 
index 85bec79..478e9d3 100644 (file)
@@ -1728,7 +1728,7 @@ body.inactive .data-grid th.sort-ascending, body.inactive .data-grid th.sort-des
 }
 
 #scripts-files {
-    max-width: 150px;
+    max-width: 250px;
 }
 
 #scripts-functions {