Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 4 May 2019 17:51:12 +0000 (17:51 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 4 May 2019 17:51:12 +0000 (17:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197549

Reviewed by Eric Carlson.

No change of behavior.

* platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
(WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm

index 83e9e5a..3552e30 100644 (file)
@@ -1,3 +1,15 @@
+2019-05-04  Youenn Fablet  <youenn@apple.com>
+
+        Convert some RealtimeOutgoingVideoSourceCocoa logging to ERROR_LOG
+        https://bugs.webkit.org/show_bug.cgi?id=197549
+
+        Reviewed by Eric Carlson.
+
+        No change of behavior.
+
+        * platform/mediastream/mac/RealtimeOutgoingVideoSourceCocoa.mm:
+        (WebCore::RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer):
+
 2019-05-03  Simon Fraser  <simon.fraser@apple.com>
 
         [macOS] Fix programmatic scrolling with async overflow scroll
index 5e7e124..6f6d471 100644 (file)
@@ -75,7 +75,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
         VTImageRotationSessionRef rawRotationSession = nullptr;
         auto status = VTImageRotationSessionCreate(kCFAllocatorDefault, rotation, &rawRotationSession);
         if (status != noErr) {
-            ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a rotation session with error ", status);
+            ERROR_LOG(LOGIDENTIFIER, "Failed creating a rotation session with error ", status);
             return nullptr;
         }
 
@@ -100,7 +100,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
         auto status = CVPixelBufferPoolCreate(kCFAllocatorDefault, nullptr, (__bridge CFDictionaryRef)pixelAttributes, &pool);
 
         if (status != kCVReturnSuccess) {
-            ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer pool with error ", status);
+            ERROR_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer pool with error ", status);
             return nullptr;
         }
         m_rotationPool = adoptCF(pool);
@@ -114,7 +114,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
     auto status = CVPixelBufferPoolCreatePixelBuffer(kCFAllocatorDefault, m_rotationPool.get(), &rawRotatedBuffer);
 
     if (status != kCVReturnSuccess) {
-        ALWAYS_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer with error ", status);
+        ERROR_LOG(LOGIDENTIFIER, "Failed creating a pixel buffer with error ", status);
         return nullptr;
     }
     RetainPtr<CVPixelBufferRef> rotatedBuffer = adoptCF(rawRotatedBuffer);
@@ -122,7 +122,7 @@ RetainPtr<CVPixelBufferRef> RealtimeOutgoingVideoSourceCocoa::rotatePixelBuffer(
     status = VTImageRotationSessionTransferImage(m_rotationSession.get(), pixelBuffer, rotatedBuffer.get());
 
     if (status != noErr) {
-        ALWAYS_LOG(LOGIDENTIFIER, "Failed rotating with error ", status);
+        ERROR_LOG(LOGIDENTIFIER, "Failed rotating with error ", status, " for rotation ", m_currentRotation);
         return nullptr;
     }
     return rotatedBuffer;