AX: Inaccessible content on webkit.org main page
authorjcraig@apple.com <jcraig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 May 2017 21:36:32 +0000 (21:36 +0000)
committerjcraig@apple.com <jcraig@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 May 2017 21:36:32 +0000 (21:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=172106

Reviewed by Joseph Pecoraro.

* wp-content/themes/webkit/widgets/icon.php: Resolved link title.
* wp-content/themes/webkit/widgets/post.php: Resolved link title.
* wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/webkit.org/ChangeLog
Websites/webkit.org/wp-content/themes/webkit/widgets/icon.php
Websites/webkit.org/wp-content/themes/webkit/widgets/post.php
Websites/webkit.org/wp-content/themes/webkit/widgets/twitter.php

index be5ce85..5464b8f 100644 (file)
@@ -1,3 +1,14 @@
+2017-05-15  James Craig  <jcraig@apple.com>
+
+        AX: Inaccessible content on webkit.org main page
+        https://bugs.webkit.org/show_bug.cgi?id=172106
+
+        Reviewed by Joseph Pecoraro.
+
+        * wp-content/themes/webkit/widgets/icon.php: Resolved link title.
+        * wp-content/themes/webkit/widgets/post.php: Resolved link title.
+        * wp-content/themes/webkit/widgets/twitter.php: Resolved link titles. Suppressed unlabeled images with alt="".
+
 2017-05-14  James Craig  <jcraig@apple.com>
 
         Upload poster images and working captioned video
index a594715..a477975 100644 (file)
@@ -30,7 +30,7 @@ class WebKitIconTileWidget extends WP_Widget {
         
         ?>
         <div class="<?php echo esc_attr(join(' ', $classes)); ?>">
-            <a class="tile-link" href="<?php echo esc_url($url); ?>">Clickable link</a>
+            <a class="tile-link" href="<?php echo esc_url($url); ?>"><?php echo nl2br(esc_html($text)); ?></a>
             <div class="icon"></div>
             <h2><?php echo nl2br(esc_html($text)); ?></h2>
             <?php if (!empty($subtext)): ?><p><?php echo nl2br(esc_html($subtext)); ?></p><?php endif; ?>
index 86f0dc4..d99e70b 100644 (file)
@@ -59,7 +59,7 @@ class WebKitPostTileWidget extends WP_Widget {
         
         ?>
             <div <?php echo post_class(join(' ', $classes)); ?>>
-                <a class="tile-link" href="<?php the_permalink(); ?>">Clickable link</a>
+                <a class="tile-link" href="<?php the_permalink(); ?>"><?php echo $title; ?></a>
                 <div class="background-image">
                     <div class="featured-image"<?php echo $image; ?>></div>
                     <?php if ( $featured ): ?><div class="background-vignette"></div><?php endif; ?>
index 4d357c0..c8b9a06 100644 (file)
@@ -68,10 +68,10 @@ class WebKitTwitterTileWidget extends WebKitPostTileWidget {
 
         ?>
         <div class="<?php echo esc_attr(join(' ', $classes)); ?>">
-            <a href="<?php echo esc_url($link); ?>" class="tile-link">Clickable link to tweet</a>
+            <a href="<?php echo esc_url($link); ?>" class="tile-link">Tweet: <?php echo $text; ?></a>
             <div class="tile-content">
             <?php if ( ! empty($Image) ): ?>
-            <img src="<?php echo esc_url($Image->media_url_https); ?>">
+            <img src="<?php echo esc_url($Image->media_url_https); ?>" alt="">
             <?php else: ?>
             <?php endif;?>
                 <p><?php echo $text; ?></p>
@@ -94,7 +94,7 @@ class WebKitTwitterTileWidget extends WebKitPostTileWidget {
 
         ?>
         <div class="<?php echo esc_attr(join(' ', $classes)); ?>">
-            <a class="tile-link" href="<?php echo esc_url($url); ?>">Clickable link</a>
+            <a class="tile-link" href="<?php echo esc_url($url); ?>"><?php echo nl2br(esc_html($options['text'])); ?></a>
             <div class="icon twitter-icon"></div>
             <h2><?php echo nl2br(esc_html($options['text'])); ?></h2>
         </div>