[mac-wk1] LayoutTest media/modern-media-controls/forward-button/forward-button.html...
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 14 Feb 2017 17:29:35 +0000 (17:29 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 14 Feb 2017 17:29:35 +0000 (17:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=168265

Unreviewed test gardening.

* media/modern-media-controls/forward-button/forward-button-expected.txt:
* media/modern-media-controls/forward-button/forward-button.html:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@212304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/forward-button/forward-button-expected.txt
LayoutTests/media/modern-media-controls/forward-button/forward-button.html
LayoutTests/platform/mac-wk1/TestExpectations

index 3f14ddb..f981e98 100644 (file)
@@ -1,3 +1,14 @@
+2017-02-14  Antoine Quint  <graouts@apple.com>
+
+        [mac-wk1] LayoutTest media/modern-media-controls/forward-button/forward-button.html is a flaky timeout
+        https://bugs.webkit.org/show_bug.cgi?id=168265
+
+        Unreviewed test gardening.
+
+        * media/modern-media-controls/forward-button/forward-button-expected.txt:
+        * media/modern-media-controls/forward-button/forward-button.html:
+        * platform/mac-wk1/TestExpectations:
+
 2017-02-13  Filip Pizlo  <fpizlo@apple.com>
 
         worker.postMessage should throw a TypeError if a SharedArrayBuffer is in the transfer list
index ab10f49..764997d 100644 (file)
@@ -7,7 +7,7 @@ PASS forwardButton.element.localName is "button"
 PASS forwardButton.element.classList.contains("icon") is true
 PASS forwardButton.element.classList.contains("forward") is true
 PASS forwardButton.iconName is "forward"
-PASS forwardButton.element.style.webkitMaskImage.includes("macOS/forward@") is true
+PASS forwardButton.element.style.webkitMaskImage.includes("macOS/forward@") became true
 PASS successfullyParsed is true
 
 TEST COMPLETE
index 95a67fe..74f0a4a 100644 (file)
@@ -8,8 +8,6 @@ window.jsTestIsAsync = true;
 
 description("Testing the <code>ForwardButton</code> class.");
 
-iconService.directoryPath = "../../../../Source/WebCore/Modules/modern-media-controls/images";
-
 const forwardButton = new ForwardButton({ layoutTraits: LayoutTraits.macOS });
 
 shouldBeEqualToString("forwardButton.element.localName", "button");
@@ -17,14 +15,7 @@ shouldBeTrue('forwardButton.element.classList.contains("icon")');
 shouldBeTrue('forwardButton.element.classList.contains("forward")');
 shouldBeEqualToString("forwardButton.iconName", `${Icons.Forward}`);
 
-scheduler.frameDidFire = function()
-{
-    if (forwardButton.width == 0)
-        return;
-
-    shouldBeTrue('forwardButton.element.style.webkitMaskImage.includes("macOS/forward@")');
-    finishMediaControlsTest();
-};
+shouldBecomeEqual('forwardButton.element.style.webkitMaskImage.includes("macOS/forward@")', "true", finishMediaControlsTest);
 
 </script>
 <script src="../../../resources/js-test-post.js"></script>
index 3ba5ba1..dd6e3e7 100644 (file)
@@ -305,8 +305,6 @@ media/track/track-cue-rendering-horizontal.html [ Pass Crash ]
 media/accessibility-closed-captions-has-aria-owns.html [ Pass Crash ]
 media/track/track-cues-enter-exit.html [ Pass Crash ]
 
-webkit.org/b/168265 media/modern-media-controls/forward-button/forward-button.html [ Pass Timeout ]
-
 webkit.org/b/167127 pointer-lock/locked-element-removed-from-dom.html
 
 webkit.org/b/167857 pageoverlay/overlay-remove-reinsert-view.html [ Skip ]