Web Inspector: REGRESSION (r191612): Storage sidebar panel tree outline is broken
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Nov 2015 01:48:47 +0000 (01:48 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Nov 2015 01:48:47 +0000 (01:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=150862

Reviewed by Joseph Pecoraro.

* UserInterface/Views/ApplicationCacheFrameContentView.js:
Inherit from ContentView.

* UserInterface/Views/StorageSidebarPanel.js:
(WebInspector.StorageSidebarPanel.prototype._addDatabase):
Fixed syntax error.
(WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
(WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
WebInspector.TreeOutline.append doesn't exist; changed to appendChild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@192005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js
Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js

index 6a8cf94..6146a3b 100644 (file)
@@ -1,5 +1,22 @@
 2015-11-03  Matt Baker  <mattbaker@apple.com>
 
+        Web Inspector: REGRESSION (r191612): Storage sidebar panel tree outline is broken
+        https://bugs.webkit.org/show_bug.cgi?id=150862
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/ApplicationCacheFrameContentView.js:
+        Inherit from ContentView.
+
+        * UserInterface/Views/StorageSidebarPanel.js:
+        (WebInspector.StorageSidebarPanel.prototype._addDatabase):
+        Fixed syntax error.
+        (WebInspector.StorageSidebarPanel.prototype._addIndexedDatabase):
+        (WebInspector.StorageSidebarPanel.prototype._addFrameManifest):
+        WebInspector.TreeOutline.append doesn't exist; changed to appendChild.
+
+2015-11-03  Matt Baker  <mattbaker@apple.com>
+
         Web Inspector: Create View base class, refactor some core view classes
         https://bugs.webkit.org/show_bug.cgi?id=149186
 
index 63eaac7..0186dc3 100644 (file)
@@ -23,7 +23,7 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-WebInspector.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView extends WebInspector.ApplicationCacheFrame
+WebInspector.ApplicationCacheFrameContentView = class ApplicationCacheFrameContentView extends WebInspector.ContentView
 {
     constructor(representedObject)
     {
index e9423df..3adc64d 100644 (file)
@@ -215,11 +215,11 @@ WebInspector.StorageSidebarPanel = class StorageSidebarPanel extends WebInspecto
         if (!databaseHostElement) {
             databaseHostElement = new WebInspector.DatabaseHostTreeElement(database.host);
             this._databaseHostTreeElementMap.set(database.host, databaseHostElement);
-            this._databaseRootTreeElement = this._addStorageChild(treeElement, this._databaseRootTreeElement, WebInspector.UIString("Databases"));
+            this._databaseRootTreeElement = this._addStorageChild(databaseHostElement, this._databaseRootTreeElement, WebInspector.UIString("Databases"));
         }
 
         let databaseElement = new WebInspector.DatabaseTreeElement(database);
-        databaseHostElement.append(databaseElement);
+        databaseHostElement.appendChild(databaseElement);
     }
 
     _databaseWasInspected(event)
@@ -246,7 +246,7 @@ WebInspector.StorageSidebarPanel = class StorageSidebarPanel extends WebInspecto
         }
 
         let indexedDatabaseElement = new WebInspector.IndexedDatabaseTreeElement(indexedDatabase);
-        indexedDatabaseHostElement.append(indexedDatabaseElement);
+        indexedDatabaseHostElement.appendChild(indexedDatabaseElement);
     }
 
     _cookieStorageObjectWasAdded(event)
@@ -281,7 +281,7 @@ WebInspector.StorageSidebarPanel = class StorageSidebarPanel extends WebInspecto
         }
 
         let frameCacheElement = new WebInspector.ApplicationCacheFrameTreeElement(frameManifest);
-        applicationCacheManifestElement.append(frameCacheElement);
+        applicationCacheManifestElement.appendChild(frameCacheElement);
     }
 
     _frameManifestRemoved(event)