RealtimeOutgoingAudioSource::pullAudioData is no longer needed
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Aug 2019 23:25:45 +0000 (23:25 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Aug 2019 23:25:45 +0000 (23:25 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200450

Reviewed by Geoffrey Garen.

No change of behavior, removing base class method declaration.

* platform/mediastream/RealtimeOutgoingAudioSource.h:
(WebCore::RealtimeOutgoingAudioSource::pullAudioData): Deleted.
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h
Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h
Source/WebCore/platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h

index 11f45d9..a2108bd 100644 (file)
@@ -1,3 +1,17 @@
+2019-08-05  Youenn Fablet  <youenn@apple.com>
+
+        RealtimeOutgoingAudioSource::pullAudioData is no longer needed
+        https://bugs.webkit.org/show_bug.cgi?id=200450
+
+        Reviewed by Geoffrey Garen.
+
+        No change of behavior, removing base class method declaration.
+
+        * platform/mediastream/RealtimeOutgoingAudioSource.h:
+        (WebCore::RealtimeOutgoingAudioSource::pullAudioData): Deleted.
+        * platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h:
+        * platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.h:
+
 2019-08-05  Saam Barati  <sbarati@apple.com>
 
         [WHLSL] Add compile time flag to dump metal compile times
index 8385fa4..4195d7b 100644 (file)
@@ -74,8 +74,6 @@ protected:
 
     void unobserveSource();
 
-    virtual void pullAudioData() { }
-
     bool isSilenced() const { return m_muted || !m_enabled; }
 
     void sendAudioFrames(const void* audioData, int bitsPerSample, int sampleRate, size_t numberOfChannels, size_t numberOfFrames);
index 090405e..39ce88b 100644 (file)
@@ -46,7 +46,7 @@ private:
     bool isReachingBufferedAudioDataLowLimit() final;
     bool hasBufferedEnoughData() final;
 
-    void pullAudioData() final;
+    void pullAudioData();
 
     GUniquePtr<GstAudioConverter> m_sampleConverter;
     std::unique_ptr<GStreamerAudioStreamDescription> m_inputStreamDescription;
index b132be6..d6e971a 100644 (file)
@@ -52,7 +52,7 @@ private:
     bool hasBufferedEnoughData() final;
     void sourceUpdated() final;
 
-    void pullAudioData() final;
+    void pullAudioData();
 
     Ref<AudioSampleDataSource> m_sampleConverter;
     CAAudioStreamDescription m_inputStreamDescription;