[GTK] Remove notifications guards from GTK API layer
authorcsaavedra@igalia.com <csaavedra@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 May 2017 12:54:25 +0000 (12:54 +0000)
committercsaavedra@igalia.com <csaavedra@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 11 May 2017 12:54:25 +0000 (12:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170014

Reviewed by Michael Catanzaro.

ENABLE_NOTIFICATIONS in the GTK port is a private option and
disabling it is unsupported, hence remove its guards from the GTK API
layer.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp

index d6ed692..34f2f4f 100644 (file)
@@ -1,3 +1,17 @@
+2017-05-11  Claudio Saavedra  <csaavedra@igalia.com>
+
+        [GTK] Remove notifications guards from GTK API layer
+        https://bugs.webkit.org/show_bug.cgi?id=170014
+
+        Reviewed by Michael Catanzaro.
+
+        ENABLE_NOTIFICATIONS in the GTK port is a private option and
+        disabling it is unsupported, hence remove its guards from the GTK API
+        layer.
+
+        * UIProcess/API/gtk/WebKitWebContext.cpp:
+        (webkitWebContextConstructed):
+
 2017-05-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.2 release.
index bc3b896..9629314 100644 (file)
@@ -168,9 +168,7 @@ struct _WebKitWebContextPrivate {
 #if ENABLE(GEOLOCATION)
     RefPtr<WebKitGeolocationProvider> geolocationProvider;
 #endif
-#if ENABLE(NOTIFICATIONS)
     RefPtr<WebKitNotificationProvider> notificationProvider;
-#endif
     GRefPtr<WebKitWebsiteDataManager> websiteDataManager;
 
     CString faviconDatabaseDirectory;
@@ -327,9 +325,7 @@ static void webkitWebContextConstructed(GObject* object)
 #if ENABLE(GEOLOCATION)
     priv->geolocationProvider = WebKitGeolocationProvider::create(priv->processPool->supplement<WebGeolocationManagerProxy>());
 #endif
-#if ENABLE(NOTIFICATIONS)
     priv->notificationProvider = WebKitNotificationProvider::create(priv->processPool->supplement<WebNotificationManagerProxy>(), webContext);
-#endif
 #if ENABLE(REMOTE_INSPECTOR)
     priv->remoteInspectorProtocolHandler = std::make_unique<RemoteInspectorProtocolHandler>(webContext);
 #endif