2008-04-16 Anders Carlsson <andersca@apple.com>
authorandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 Apr 2008 00:22:03 +0000 (00:22 +0000)
committerandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 Apr 2008 00:22:03 +0000 (00:22 +0000)
        Reviewed by Sam.

        Fix some style nits.

        * loader/appcache/ApplicationCache.cpp:
        (WebCore::ApplicationCache::ApplicationCache):
        (WebCore::ApplicationCache::setManifestResource):
        (WebCore::ApplicationCache::addResource):
        (WebCore::ApplicationCache::removeResource):
        (WebCore::ApplicationCache::dump):
        * loader/appcache/ApplicationCacheGroup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/loader/appcache/ApplicationCache.cpp
WebCore/loader/appcache/ApplicationCacheGroup.h

index 4a7955e..f6bfcc4 100644 (file)
@@ -1,5 +1,19 @@
 2008-04-16  Anders Carlsson  <andersca@apple.com>
 
+        Reviewed by Sam.
+        
+        Fix some style nits.
+        
+        * loader/appcache/ApplicationCache.cpp:
+        (WebCore::ApplicationCache::ApplicationCache):
+        (WebCore::ApplicationCache::setManifestResource):
+        (WebCore::ApplicationCache::addResource):
+        (WebCore::ApplicationCache::removeResource):
+        (WebCore::ApplicationCache::dump):
+        * loader/appcache/ApplicationCacheGroup.h:
+
+2008-04-16  Anders Carlsson  <andersca@apple.com>
+
         Reviewed by Brady and Sam.
 
         Add ApplicationCache implementation. Stub out ApplicationCacheGroup methods
index 9badb5c..31e7c72 100644 (file)
@@ -38,7 +38,7 @@ ApplicationCache::ApplicationCache(ApplicationCacheGroup* group)
     : m_group(group)
     , m_manifest(0)
 {
-    ASSERT(m_group);
+    ASSERT_ARG(group);
 }
 
 ApplicationCache::~ApplicationCache()
@@ -48,9 +48,8 @@ ApplicationCache::~ApplicationCache()
 
 void ApplicationCache::setManifestResource(PassRefPtr<ApplicationCacheResource> manifest)
 {
-    ASSERT(manifest);
+    ASSERT_ARG(manifest);
     ASSERT(!m_manifest);
-
     ASSERT(manifest->type() & ApplicationCacheResource::Manifest);
     
     m_manifest = manifest.get();
@@ -60,7 +59,7 @@ void ApplicationCache::setManifestResource(PassRefPtr<ApplicationCacheResource>
     
 void ApplicationCache::addResource(PassRefPtr<ApplicationCacheResource> resource)
 {
-    ASSERT(resource);
+    ASSERT_ARG(resource);
     
     const String& url = resource->url();
     
@@ -71,7 +70,6 @@ void ApplicationCache::addResource(PassRefPtr<ApplicationCacheResource> resource
 
 unsigned ApplicationCache::removeResource(const String& url)
 {
-    
     HashMap<String, RefPtr<ApplicationCacheResource> >::iterator it = m_resources.find(url);
     if (it == m_resources.end())
         return 0;
@@ -154,7 +152,6 @@ void ApplicationCache::dump()
         ApplicationCacheResource::dumpType(it->second->type());
     }
 }
-    
 #endif
 
 }
index 60c2666..637a22b 100644 (file)
@@ -39,6 +39,7 @@ public:
     const KURL& manifestURL() const { return m_manifestURL; }
     
     void cacheDestroyed(ApplicationCache*) { }
+    
 private:
     KURL m_manifestURL;
 };