REGERSSION (r73310?): Contents of <select> popup menus are upside-down on Windows
authorandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Dec 2010 19:59:40 +0000 (19:59 +0000)
committerandersca@apple.com <andersca@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 6 Dec 2010 19:59:40 +0000 (19:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=50544
<rdar://problem/8732336>

Reviewed by Dan Bernstein.

* Shared/BackingStore.cpp:
* Shared/BackingStore.h:
* Shared/cairo/BackingStoreCairo.cpp:
Remove BackingStore::createFlippedGraphicsContext.

* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):
Don't create a flipped graphics context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@73383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit2/ChangeLog
WebKit2/Shared/BackingStore.cpp
WebKit2/Shared/BackingStore.h
WebKit2/Shared/cairo/BackingStoreCairo.cpp
WebKit2/WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp

index e5554f3..06898d6 100644 (file)
@@ -2,6 +2,23 @@
 
         Reviewed by Dan Bernstein.
 
+        REGERSSION (r73310?): Contents of <select> popup menus are upside-down on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=50544
+        <rdar://problem/8732336>
+
+        * Shared/BackingStore.cpp:
+        * Shared/BackingStore.h:
+        * Shared/cairo/BackingStoreCairo.cpp:
+        Remove BackingStore::createFlippedGraphicsContext.
+
+        * WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
+        (WebKit::WebPopupMenu::setUpPlatformData):
+        Don't create a flipped graphics context.
+
+2010-12-06  Anders Carlsson  <andersca@apple.com>
+
+        Reviewed by Dan Bernstein.
+
         REGRESSION: Text in Find indicator is vertically flipped
         https://bugs.webkit.org/show_bug.cgi?id=50524
         <rdar://problem/8732978>
index f64c0a7..4244eaa 100644 (file)
@@ -125,15 +125,4 @@ void* BackingStore::data() const
     return m_data;
 }
 
-PassOwnPtr<GraphicsContext> BackingStore::createFlippedGraphicsContext()
-{
-    OwnPtr<GraphicsContext> graphicsContext = createGraphicsContext();
-
-    // Flip the coordinate system.
-    graphicsContext->translate(0, m_size.height());
-    graphicsContext->scale(FloatSize(1, -1));
-
-    return graphicsContext.release();
-}
-    
 } // namespace WebKit
index ee90d3a..7b3c905 100644 (file)
@@ -62,7 +62,6 @@ public:
 
     // Create a graphics context that can be used to paint into the backing store.
     PassOwnPtr<WebCore::GraphicsContext> createGraphicsContext();
-    PassOwnPtr<WebCore::GraphicsContext> createFlippedGraphicsContext();
 
     // Paint the backing store into the given context.
     void paint(WebCore::GraphicsContext&, const WebCore::IntPoint& dstPoint, const WebCore::IntRect& srcRect);
index 105c5e5..ac18dfb 100644 (file)
@@ -38,12 +38,6 @@ PassOwnPtr<GraphicsContext> BackingStore::createGraphicsContext()
     return 0;
 }
 
-PassOwnPtr<GraphicsContext> BackingStore::createFlippedGraphicsContext()
-{
-    notImplemented();
-    return 0;
-}
-
 void BackingStore::paint(GraphicsContext&, const IntPoint&, const IntRect&)
 {
     notImplemented();
index 96bac62..561141f 100644 (file)
@@ -78,8 +78,8 @@ void WebPopupMenu::setUpPlatformData(PlatformPopupMenuData& data)
     data.m_notSelectedBackingStore = BackingStore::createSharable(data.m_backingStoreSize);
     data.m_selectedBackingStore = BackingStore::createSharable(data.m_backingStoreSize);
 
-    OwnPtr<GraphicsContext> notSelectedBackingStoreContext = data.m_notSelectedBackingStore->createFlippedGraphicsContext();
-    OwnPtr<GraphicsContext> selectedBackingStoreContext = data.m_selectedBackingStore->createFlippedGraphicsContext();
+    OwnPtr<GraphicsContext> notSelectedBackingStoreContext = data.m_notSelectedBackingStore->createGraphicsContext();
+    OwnPtr<GraphicsContext> selectedBackingStoreContext = data.m_selectedBackingStore->createGraphicsContext();
 
     Color activeOptionBackgroundColor = RenderTheme::defaultTheme()->activeListBoxSelectionBackgroundColor();
     Color activeOptionTextColor = RenderTheme::defaultTheme()->activeListBoxSelectionForegroundColor();