Unreviewed, rolling out r233741.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Jul 2018 00:08:39 +0000 (00:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 12 Jul 2018 00:08:39 +0000 (00:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187568

"WKTR vs exp features, booooooo" (Requested by bradee-oh on
#webkit).

Reverted changeset:

"Make process-swap-on-navigation an experimental feature."
https://bugs.webkit.org/show_bug.cgi?id=187558
https://trac.webkit.org/changeset/233741

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/UIProcess/WebPreferences.cpp
Source/WebKit/UIProcess/WebProcessPool.cpp

index 767022b..84fc9da 100644 (file)
@@ -1,3 +1,17 @@
+2018-07-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r233741.
+        https://bugs.webkit.org/show_bug.cgi?id=187568
+
+        "WKTR vs exp features, booooooo" (Requested by bradee-oh on
+        #webkit).
+
+        Reverted changeset:
+
+        "Make process-swap-on-navigation an experimental feature."
+        https://bugs.webkit.org/show_bug.cgi?id=187558
+        https://trac.webkit.org/changeset/233741
+
 2018-07-11  Brady Eidson  <beidson@apple.com>
 
         Make process-swap-on-navigation an experimental feature.
index c73c4dd..0ec44f6 100644 (file)
@@ -1283,12 +1283,3 @@ EncryptedMediaAPIEnabled:
   webcoreBinding: RuntimeEnabledFeatures
   category: experimental
   condition: ENABLE(ENCRYPTED_MEDIA)
-
-ProcessSwapOnNavigationEnabled:
-  type: bool
-  defaultValue: false
-  humanReadableName: "Swap Processes on Navigation"
-  humanReadableDescription: "Swap WebContent processes on cross-origin navigations"
-  category: experimental
-  webcoreBinding: none
-
index 62cadec..830e0d7 100644 (file)
@@ -133,13 +133,6 @@ void WebPreferences::updateBoolValueForKey(const String& key, bool value)
 
 void WebPreferences::updateBoolValueForExperimentalFeatureKey(const String& key, bool value)
 {
-    if (key == WebPreferencesKey::processSwapOnNavigationEnabledKey()) {
-        for (auto* page : m_pages)
-            page->process().processPool().configuration().setProcessSwapsOnNavigation(value);
-
-        return;
-    }
-
     update(); // FIXME: Only send over the changed key and value.
 }
 
index e81e20b..6991438 100644 (file)
@@ -1149,11 +1149,7 @@ Ref<WebPageProxy> WebProcessPool::createWebPage(PageClient& pageClient, Ref<API:
     ASSERT(!is<ServiceWorkerProcessProxy>(*process));
 #endif
 
-    auto page = process->createWebPage(pageClient, WTFMove(pageConfiguration));
-    if (page->preferences().processSwapOnNavigationEnabled())
-        m_configuration->setProcessSwapsOnNavigation(true);
-
-    return page;
+    return process->createWebPage(pageClient, WTFMove(pageConfiguration));
 }
 
 #if ENABLE(SERVICE_WORKER)