fast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 Sep 2014 05:32:33 +0000 (05:32 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 Sep 2014 05:32:33 +0000 (05:32 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136716

Reviewed by Darin Adler.

This test used a fake timeout handler, which is not needed, because WRT/WKTR do it for you.
Any time the test took over 2 seconds, we would dump and disable waiting for notifyDone,
but the test would still try to open windows after that.

* fast/forms/submit-to-blank-multiple-times.html:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/forms/submit-to-blank-multiple-times.html
LayoutTests/platform/mac/TestExpectations

index 54f0668..1948fa9 100644 (file)
@@ -1,3 +1,17 @@
+2014-09-11  Alexey Proskuryakov  <ap@apple.com>
+
+        fast/forms/submit-to-blank-multiple-times.html crashes with JSC_slowPathAllocsBetweenGCs
+        https://bugs.webkit.org/show_bug.cgi?id=136716
+
+        Reviewed by Darin Adler.
+
+        This test used a fake timeout handler, which is not needed, because WRT/WKTR do it for you.
+        Any time the test took over 2 seconds, we would dump and disable waiting for notifyDone,
+        but the test would still try to open windows after that.
+
+        * fast/forms/submit-to-blank-multiple-times.html:
+        * platform/mac/TestExpectations:
+
 2014-09-11  Shivakumar JM  <shiva.jm@samsung.com>
 
         The overrideMimeType in XMLHttpRequest should throw the exception.
index 6d82177..22fbd5a 100644 (file)
@@ -20,6 +20,7 @@
         if (window.testRunner) {
             testRunner.dumpAsText();
             testRunner.setCanOpenWindows();
+            testRunner.setCloseRemainingWindowsWhenComplete();
             testRunner.waitUntilDone();
         }
         var numberTimesToClick = 2;
@@ -29,8 +30,6 @@
                 return;
             
             click();
-            // Set a timeout to notify done in case the test fails.
-            setTimeout(notifyDone, 2000);
         };
         function log(message) {
             var span = document.createElement("span");
@@ -65,7 +64,6 @@
             eventSender.keyDown(' ');
         }
         function notifyDone() {
-            testRunner.setCloseRemainingWindowsWhenComplete();
             testRunner.notifyDone();
         }
         </script>
index 2705f9f..853f803 100755 (executable)
@@ -1154,8 +1154,6 @@ webkit.org/b/131787 fast/canvas/canvas-putImageData-zero-alpha.html [ Pass Image
 
 webkit.org/b/135133 [ MountainLion ] fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/136716 fast/forms/submit-to-blank-multiple-times.html [ Skip ]
-
 webkit.org/b/136717 js/dom/string-replace-exception-crash.html [ Skip ]
 
 webkit.org/b/136718 fast/dynamic/layer-no-longer-paginated.html [ Skip ]