2008-01-21 Jan Michael Alonzo <jmalonzo@unpluggable.com>
authoralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Jan 2008 23:06:23 +0000 (23:06 +0000)
committeralp@webkit.org <alp@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Jan 2008 23:06:23 +0000 (23:06 +0000)
        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=16955
        Get errors when cross-compile webkit-gtk

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
GNUmakefile.am
JavaScriptCore/ChangeLog
JavaScriptCore/GNUmakefile.am
WebKitTools/ChangeLog
WebKitTools/GNUmakefile.am
configure.ac

index 291b617..254a202 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
+
+        Reviewed by Alp Toker.
+
+        http://bugs.webkit.org/show_bug.cgi?id=16955
+        Get errors when cross-compile webkit-gtk
+
+        * GNUmakefile.am: added ICU_CPPFLAGS
+        * configure.ac: added ICU_CPPFLAGS, removed ICU_CFLAGS
+
 2008-01-19  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 
         Reviewed by Alp Toker.
 2008-01-19  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 
         Reviewed by Alp Toker.
index 27226b8..2cb342f 100644 (file)
@@ -94,13 +94,16 @@ libJavaScriptCore_la_SOURCES = \
        $(javascriptcore_built_sources) \
        $(javascriptcore_sources)
 
        $(javascriptcore_built_sources) \
        $(javascriptcore_sources)
 
-libJavaScriptCore_la_LDFLAGS = -lpthread
+libJavaScriptCore_la_LDFLAGS = $(ICU_LIBS) -lpthread
 
 libJavaScriptCore_la_CXXFLAGS = $(global_cflags) -fstrict-aliasing
 
 libJavaScriptCore_la_CFLAGS = $(global_cflags) -fstrict-aliasing
 
 
 libJavaScriptCore_la_CXXFLAGS = $(global_cflags) -fstrict-aliasing
 
 libJavaScriptCore_la_CFLAGS = $(global_cflags) -fstrict-aliasing
 
-libJavaScriptCore_la_CPPFLAGS = $(global_cppflags) $(javascriptcore_cppflags)
+libJavaScriptCore_la_CPPFLAGS = \
+       $(global_cppflags) \
+       $(javascriptcore_cppflags) \
+       $(ICU_CPPFLAGS)
 
 #
 # WebCore
 
 #
 # WebCore
@@ -157,7 +160,8 @@ libWebKitGtk_la_CFLAGS = \
 libWebKitGtk_la_CPPFLAGS = \
        $(global_cppflags) \
        $(webcore_cppflags) \
 libWebKitGtk_la_CPPFLAGS = \
        $(global_cppflags) \
        $(webcore_cppflags) \
-       $(webkitgtk_cppflags)
+       $(webkitgtk_cppflags) \
+       $(ICU_CPPFLAGS)
 
 libWebKitGtk_la_LIBADD = libJavaScriptCore.la
 
 
 libWebKitGtk_la_LIBADD = libJavaScriptCore.la
 
index 8264083..b2f6a54 100644 (file)
@@ -1,3 +1,12 @@
+2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
+
+        Reviewed by Alp Toker.
+
+        http://bugs.webkit.org/show_bug.cgi?id=16955
+        Get errors when cross-compile webkit-gtk
+
+        * GNUmakefile.am: removed ICU_CFLAGS
+
 2008-01-18  Kevin McCullough  <kmccullough@apple.com>
 
         - Build fix.
 2008-01-18  Kevin McCullough  <kmccullough@apple.com>
 
         - Build fix.
index 52f7d0d..f20f302 100644 (file)
@@ -149,15 +149,15 @@ Programs_minidom_SOURCES = \
        JavaScriptCore/API/NodeList.c \
        JavaScriptCore/API/minidom.c
 Programs_minidom_CPPFLAGS = $(global_cppflags)
        JavaScriptCore/API/NodeList.c \
        JavaScriptCore/API/minidom.c
 Programs_minidom_CPPFLAGS = $(global_cppflags)
-Programs_minidom_CXXFLAGS = $(global_cflags) $(ICU_CFLAGS)
-Programs_minidom_LDADD = $(ICU_LIBS) libJavaScriptCore.la
+Programs_minidom_CXXFLAGS = $(global_cflags)
+Programs_minidom_LDADD = libJavaScriptCore.la
 Programs_minidom_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # testkjs
 Programs_testkjs_SOURCES = JavaScriptCore/kjs/testkjs.cpp
 Programs_testkjs_CPPFLAGS = $(global_cppflags)
 Programs_minidom_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # testkjs
 Programs_testkjs_SOURCES = JavaScriptCore/kjs/testkjs.cpp
 Programs_testkjs_CPPFLAGS = $(global_cppflags)
-Programs_testkjs_CXXFLAGS = $(global_cflags) $(ICU_CFLAGS)
-Programs_testkjs_LDADD = $(ICU_LIBS) libJavaScriptCore.la
+Programs_testkjs_CXXFLAGS = $(global_cflags)
+Programs_testkjs_LDADD = libJavaScriptCore.la
 Programs_testkjs_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # Clean rules for JavaScriptCore
 Programs_testkjs_LDFLAGS = -rpath $(CURDIR)/.libs
 
 # Clean rules for JavaScriptCore
index 620647e..2fb13f1 100644 (file)
@@ -1,3 +1,12 @@
+2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
+
+        Reviewed by Alp Toker.
+
+        http://bugs.webkit.org/show_bug.cgi?id=16955
+        Get errors when cross-compile webkit-gtk
+
+        * GNUmakefile.am: Removed ICU_CFLAGS 
+
 2008-01-21  Darin Adler  <darin@apple.com>
 
         Reviewed by Mitz and Adam.
 2008-01-21  Darin Adler  <darin@apple.com>
 
         Reviewed by Mitz and Adam.
index e070587..f211ee6 100644 (file)
@@ -12,17 +12,10 @@ Programs_GtkLauncher_SOURCES = \
 
 Programs_GtkLauncher_CFLAGS = \
        $(DEPENDENCIES_CFLAGS) \
 
 Programs_GtkLauncher_CFLAGS = \
        $(DEPENDENCIES_CFLAGS) \
-       $(ICU_CFLAGS) \
-       $(SQLITE3_CFLAGS) \
-       $(GSTREAMER_CFLAGS) \
-       $(LIBXSLT_CFLAGS)
+       $(global_cflags)
 
 Programs_GtkLauncher_LDADD = \
        $(DEPENDENCIES_LIBS) \
 
 Programs_GtkLauncher_LDADD = \
        $(DEPENDENCIES_LIBS) \
-       $(ICU_LIBS) \
-       $(SQLITE3_LIBS) \
-       $(GSTREAMER_LIBS) \
-       $(LIBXSLT_LIBS) \
        libJavaScriptCore.la \
        libWebKitGtk.la
 
        libJavaScriptCore.la \
        libWebKitGtk.la
 
@@ -44,6 +37,13 @@ Programs_DumpRenderTree_SOURCES = \
        WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp \
        WebKitTools/DumpRenderTree/gtk/WorkQueueItemGtk.cpp
 
        WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp \
        WebKitTools/DumpRenderTree/gtk/WorkQueueItemGtk.cpp
 
-Programs_DumpRenderTree_CXXFLAGS = $(DEPENDENCIES_CFLAGS) $(AM_CXXFLAGS)
-Programs_DumpRenderTree_LDADD = $(DEPENDENCIES_LIBS) libJavaScriptCore.la libWebKitGtk.la
+Programs_DumpRenderTree_CXXFLAGS = \
+       $(DEPENDENCIES_CFLAGS) \
+       $(global_cflags)
+
+Programs_DumpRenderTree_LDADD = \
+       $(DEPENDENCIES_LIBS) \
+       libJavaScriptCore.la \
+       libWebKitGtk.la
+
 Programs_DumpRenderTree_LDFLAGS = -rpath $(CURDIR)/.libs 
 Programs_DumpRenderTree_LDFLAGS = -rpath $(CURDIR)/.libs 
index 5e2453e..1a7dc57 100644 (file)
@@ -129,9 +129,13 @@ AC_PATH_PROG(icu_config, icu-config, no)
 if test "$icu_config" = "no"; then
    AC_MSG_ERROR([Cannot find icu-config. ICU library is needed.])
 fi
 if test "$icu_config" = "no"; then
    AC_MSG_ERROR([Cannot find icu-config. ICU library is needed.])
 fi
-ICU_CFLAGS=`$icu_config --cflags`
+
+# We don't use --cflags as this gives us a lot of things that we don't
+# necessarily want, like debugging and optimization flags
+# See man (1) icu-config for more info.
+ICU_CPPFLAGS=`$icu_config --cppflags`
 ICU_LIBS=`$icu_config --ldflags`
 ICU_LIBS=`$icu_config --ldflags`
-AC_SUBST([ICU_CFLAGS])
+AC_SUBST([ICU_CPPFLAGS])
 AC_SUBST([ICU_LIBS])
 
 # determine the GDK/GTK+ target
 AC_SUBST([ICU_LIBS])
 
 # determine the GDK/GTK+ target