remove 'win' from chromium-win, chromium-linux fallback paths
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Apr 2012 22:15:30 +0000 (22:15 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Apr 2012 22:15:30 +0000 (22:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=83613

Reviewed by Ojan Vafai.

The chromium ports no longer need to look at the apple 'win'
directory for baseline results.

Also remove the old '-gpu-' entries from the flakiness dashboard
map since I'm touching lines nearby.

* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
* TestResultServer/static-dashboards/flakiness_dashboard.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@113775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/layout_tests/port/chromium_linux.py
Tools/Scripts/webkitpy/layout_tests/port/chromium_win.py
Tools/TestResultServer/static-dashboards/flakiness_dashboard.html

index bffe9c2..4446323 100644 (file)
@@ -1,3 +1,22 @@
+2012-04-10  Dirk Pranke  <dpranke@chromium.org>
+
+        remove 'win' from chromium-win, chromium-linux fallback paths
+        https://bugs.webkit.org/show_bug.cgi?id=83613
+
+        Reviewed by Ojan Vafai.
+
+        The chromium ports no longer need to look at the apple 'win'
+        directory for baseline results.
+
+        Also remove the old '-gpu-' entries from the flakiness dashboard
+        map since I'm touching lines nearby.
+
+        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
+        (ChromiumLinuxPort):
+        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
+        (ChromiumWinPort):
+        * TestResultServer/static-dashboards/flakiness_dashboard.html:
+
 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
 
         [Qt][WK2] Manage graphics buffers in the web process
index b14831a..578969a 100644 (file)
@@ -46,7 +46,6 @@ class ChromiumLinuxPort(chromium.ChromiumPort):
             'chromium-linux',
             'chromium-win',
             'chromium',
-            'win',
             'mac',
         ],
         'x86': [
@@ -54,7 +53,6 @@ class ChromiumLinuxPort(chromium.ChromiumPort):
             'chromium-linux',
             'chromium-win',
             'chromium',
-            'win',
             'mac',
         ],
     }
index 4e79fb8..4096433 100755 (executable)
@@ -51,20 +51,17 @@ class ChromiumWinPort(chromium.ChromiumPort):
             'chromium-win-vista',
             'chromium-win',
             'chromium',
-            'win',
             'mac',
         ],
         'vista': [
             'chromium-win-vista',
             'chromium-win',
             'chromium',
-            'win',
             'mac',
         ],
         'win7': [
             'chromium-win',
             'chromium',
-            'win',
             'mac',
         ],
     }
index 697c6d9..62e9837 100644 (file)
@@ -2037,8 +2037,6 @@ function handleFinishedLoadingExpectations(container)
 
 // Consolidate platforms when all sub-platforms for a given platform are represented.
 // e.g., if all of the WIN- platforms are there, replace them with just WIN.
-// FIXME: Should we also consolidate "MAC-SNOWLEOPARD MAC-SNOWLEOPARD-GPU" to MAC-SNOWLEOPARD
-// or is that more confusing?
 function consolidateUsedPlatforms(container)
 {
     var allPlatforms = Object.keys(g_fallbacksMap);
@@ -2524,18 +2522,14 @@ function hideLegend()
 }
 
 var g_fallbacksMap = {};
-// FIXME: Do we still need the -GPU entries? Do we need a MAC-LION-GPU entry?
-g_fallbacksMap['WIN-XP'] = ['chromium-win-xp', 'chromium-win-vista', 'chromium-win', 'chromium', 'win', 'mac'];
-g_fallbacksMap['WIN-VISTA'] = ['chromium-win-vista', 'chromium-win', 'chromium', 'win', 'mac'];
-g_fallbacksMap['WIN-7'] = ['chromium-win', 'chromium', 'win', 'mac'];
-g_fallbacksMap['WIN-7-GPU'] = ['chromium-gpu-win'].concat(g_fallbacksMap['WIN-7']);
+g_fallbacksMap['WIN-XP'] = ['chromium-win-xp', 'chromium-win-vista', 'chromium-win', 'chromium', 'mac'];
+g_fallbacksMap['WIN-VISTA'] = ['chromium-win-vista', 'chromium-win', 'chromium', 'mac'];
+g_fallbacksMap['WIN-7'] = ['chromium-win', 'chromium', 'mac'];
 g_fallbacksMap['MAC-LEOPARD'] = ['chromium-mac-leopard', 'chromium-mac-snowleopard', 'chromium-mac', 'chromium', 'mac-leopard', 'mac-snowleopard', 'mac'];
 g_fallbacksMap['MAC-SNOWLEOPARD'] = ['chromium-mac-snowleopard', 'chromium-mac', 'chromium', 'mac-snowleopard', 'mac'];
 g_fallbacksMap['MAC-LION'] = ['chromium-mac', 'chromium', 'mac'];
-g_fallbacksMap['MAC-SNOWLEOPARD-GPU'] = ['chromium-gpu-mac'].concat(g_fallbacksMap['MAC-SNOWLEOPARD']);
-g_fallbacksMap['LINUX-32'] = ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium', 'win', 'mac'];
-g_fallbacksMap['LINUX-64'] = ['chromium-linux', 'chromium-win', 'chromium', 'win', 'mac'];
-g_fallbacksMap['LINUX-32-GPU'] = ['chromium-gpu-linux'].concat(g_fallbacksMap['LINUX-32']);
+g_fallbacksMap['LINUX-32'] = ['chromium-linux-x86', 'chromium-linux', 'chromium-win', 'chromium', 'mac'];
+g_fallbacksMap['LINUX-64'] = ['chromium-linux', 'chromium-win', 'chromium', 'mac'];
 
 function htmlForFallbackHelp(fallbacks)
 {