Fix Ember.js warnings the new perf dashboard
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 9 Nov 2014 03:21:13 +0000 (03:21 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 9 Nov 2014 03:21:13 +0000 (03:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138531

Reviewed by Darin Adler.

Fixed various warnings.

* public/v2/app.js:
(App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
* public/v2/data.js:
(PrivilegedAPI._post): Removed the superfluous console.log.
(CommitLogs.fetchForTimeRange): Ditto.
* public/v2/index.html: Added tbody as required by the HTML specification.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v2/app.js
Websites/perf.webkit.org/public/v2/data.js
Websites/perf.webkit.org/public/v2/index.html

index 232a33a..2e6c60e 100644 (file)
@@ -1,3 +1,19 @@
+2014-11-08  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Fix Ember.js warnings the new perf dashboard
+        https://bugs.webkit.org/show_bug.cgi?id=138531
+
+        Reviewed by Darin Adler.
+
+        Fixed various warnings.
+
+        * public/v2/app.js:
+        (App.InteractiveChartComponent._relayoutDataAndAxes): We can't use "rem". Use this._rem as done for x.
+        * public/v2/data.js:
+        (PrivilegedAPI._post): Removed the superfluous console.log.
+        (CommitLogs.fetchForTimeRange): Ditto.
+        * public/v2/index.html: Added tbody as required by the HTML specification.
+
 2014-11-07  Ryosuke Niwa  <rniwa@webkit.org>
 
         Fix typos in r175768.
index 46d0a1d..b8d2224 100755 (executable)
@@ -1158,7 +1158,7 @@ App.InteractiveChartComponent = Ember.Component.extend({
         this._yAxisUnitContainer = this._yAxisLabels.append("text")
             .attr("x", 0.5 * this._rem)
             .attr("y", this._rem)
-            .attr("dy", '0.8rem')
+            .attr("dy", 0.8 * this._rem)
             .style("text-anchor", "start")
             .style("z-index", "100")
             .text(this._yAxisUnit);
index 3d10e38..e50387a 100755 (executable)
@@ -44,8 +44,7 @@ PrivilegedAPI._post = function (url, parameters)
             else
                 resolve(data);
         }).fail(function (xhr, status, error) {
-            console.log(xhr);
-            reject(xhr.status + (error ? ', ' + error : ''));
+            reject(xhr.status + (error ? ', ' + error : '') + '\n\nWith response:\n' + xhr.responseText);
         });
     });
 }
@@ -77,8 +76,6 @@ CommitLogs.fetchForTimeRange = function (repository, from, to, keyword)
             return new Ember.RSVP.Promise(function (resolve) { resolve(cachedCommitsForRange); });
     }
 
-    console.log('Fecthing ' + url);
-
     return new Ember.RSVP.Promise(function (resolve, reject) {
         $.getJSON(url, function (data) {
             if (data.status != 'OK') {
index 433d1cb..8cfe0f9 100755 (executable)
 
                 <div {{bind-attr class=":bugs-pane showingBugsPane::hidden"}}>
                     <table>
-                        {{#if selectedSinglePoint}}
-                            {{#each details.bugTrackers}}
-                                <tr>
-                                    <th>{{label}}</th>
-                                    <td>
-                                        <form {{action "associateBug" this editedBugNumber on="submit"}}>
-                                            {{input type=text value=editedBugNumber}}
-                                        </form>
-                                    </td>
-                                </tr>
-                            {{/each}}
-                        {{/if}}
-                        <tr>
-                            <th>
-                                <label>Name: {{input type=text value=newAnalysisTaskName}}</label>
-                                <button {{action "createAnalysisTask"}}>Analyze</button>
-                            </th>
-                        </tr>
+                        <tbody>
+                            {{#if selectedSinglePoint}}
+                                {{#each details.bugTrackers}}
+                                    <tr>
+                                        <th>{{label}}</th>
+                                        <td>
+                                            <form {{action "associateBug" this editedBugNumber on="submit"}}>
+                                                {{input type=text value=editedBugNumber}}
+                                            </form>
+                                        </td>
+                                    </tr>
+                                {{/each}}
+                            {{/if}}
+                            <tr>
+                                <th>
+                                    <label>Name: {{input type=text value=newAnalysisTaskName}}</label>
+                                    <button {{action "createAnalysisTask"}}>Analyze</button>
+                                </th>
+                            </tr>
+                        </tbody>
                     </table>
                 </div>