Unreviewed. Follow up to r246438. This removes a debug assert until
authorsbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Jun 2019 18:59:18 +0000 (18:59 +0000)
committersbarati@apple.com <sbarati@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 14 Jun 2019 18:59:18 +0000 (18:59 +0000)
we do further compiler work in: https://bugs.webkit.org/show_bug.cgi?id=198861

* Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
(WebCore::WHLSL::checkDuplicateFunctions):
* Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp
Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt

index d1bf8cb..0aa6d08 100644 (file)
@@ -1,5 +1,14 @@
 2019-06-14  Saam Barati  <sbarati@apple.com>
 
+        Unreviewed. Follow up to r246438. This removes a debug assert until
+        we do further compiler work in: https://bugs.webkit.org/show_bug.cgi?id=198861
+
+        * Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
+        (WebCore::WHLSL::checkDuplicateFunctions):
+        * Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:
+
+2019-06-14  Saam Barati  <sbarati@apple.com>
+
         [WHLSL] Implement out-of-bounds and nullptr behavior
         https://bugs.webkit.org/show_bug.cgi?id=198600
         <rdar://problem/51668853>
index bf6c1d1..eda00ba 100644 (file)
@@ -166,7 +166,11 @@ bool checkDuplicateFunctions(const Program& program)
         //
         // Since we do that, we just need to make sure no native function is a duplicate
         // of a user-defined function.
-        ASSERT(passesStaticChecks(nativeFunctionDeclaration.get()));
+
+        // FIXME: Add back this assert once we begin to auto generate these in the compiler
+        // instead of having them in the stdlib
+        // https://bugs.webkit.org/show_bug.cgi?id=198861
+        // ASSERT(passesStaticChecks(nativeFunctionDeclaration.get()));
         if (functions.contains(DuplicateFunctionKey { nativeFunctionDeclaration.get() }))
             return false;
     }
index dc0cfe7..0749481 100644 (file)
@@ -441,9 +441,12 @@ native bool operator<(uint, uint);
 native bool operator<(float, float);
 native bool operator==(float, float);
 native bool operator==(int, int);
-native bool operator==(thread int*, thread int*);
 native float operator*(float, float);
 
+// FIXME: These should be auto generated by the compiler.
+// https://bugs.webkit.org/show_bug.cgi?id=198861
+native bool operator==(thread int*, thread int*);
+
 native bool operator.x(bool2);
 native bool operator.y(bool2);
 native bool operator.x(bool3);