LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Apr 2017 18:00:06 +0000 (18:00 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Apr 2017 18:00:06 +0000 (18:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=167965

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-04-03
Reviewed by Jon Lee.

Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
can therefore be delivered later than expected by the test. This is already done for the first one,
do this for the second one also.

* platform/mac-wk2/TestExpectations:
* pointer-lock/mouse-event-delivery.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-wk2/TestExpectations
LayoutTests/pointer-lock/mouse-event-delivery.html

index ada65c0..da02c38 100644 (file)
@@ -1,3 +1,17 @@
+2017-04-03  Jeremy Jones  <jeremyj@apple.com>
+
+        LayoutTest pointer-lock/mouse-event-delivery.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=167965
+
+        Reviewed by Jon Lee.
+
+        Wait for wheel event before doing next step of test. The wheel event is delivered asynchronously and
+        can therefore be delivered later than expected by the test. This is already done for the first one,
+        do this for the second one also.
+
+        * platform/mac-wk2/TestExpectations:
+        * pointer-lock/mouse-event-delivery.html:
+
 2017-04-01  Simon Fraser  <simon.fraser@apple.com>
 
         Clean up touch event handler registration when moving nodes between documents
index e08b235..6d6a80e 100644 (file)
@@ -619,8 +619,6 @@ webkit.org/b/168065 inspector/unit-tests/heap-snapshot.html [ Pass Failure Timeo
 
 webkit.org/b/167538 [ Sierra ] fast/css-grid-layout/grid-simplified-layout-positioned.html [ Pass ImageOnlyFailure ]
 
-webkit.org/b/167965 pointer-lock/mouse-event-delivery.html [ Pass Failure ]
-
 webkit.org/b/168235 [ Debug ] imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html [ Pass Failure ]
 
 webkit.org/b/168085 tiled-drawing/scrolling/latched-to-deleted-node.html [ Pass Failure ]
index ede1e82..0525676 100644 (file)
         function () {
             debug("     With a lock in place send a wheel event.")
             targetdiv1.onwheel = eventNotExpected;
-            targetdiv2.onwheel = eventExpected;
+            targetdiv2.onwheel = eventExpectedThenNextStep;
             document.body.onwheel = eventExpected;
             if (window.eventSender) {
                 window.eventSender.leapForward(1000);
                 window.eventSender.mouseScrollBy(0,10);
             }
-            doNextStep();
         },
         function () {
             debug("     With a lock in place send a click.")