Fixed an "undefined type" exception that was being thrown when
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 31 May 2008 06:05:43 +0000 (06:05 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 31 May 2008 06:05:43 +0000 (06:05 +0000)
        selecting a eval script from the file menu in the Scripts panel.
        This would also happen when stepping into an eval which would
        break other parts of the Inspector interface.

        Reviewed by Adam Roben.

        * page/inspector/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        Use the scriptOrResource variable instead of the undefined script variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/inspector/ScriptsPanel.js

index a376889..384309c 100644 (file)
@@ -1,5 +1,18 @@
 2008-05-30  Timothy Hatcher  <timothy@apple.com>
 
+        Fixed an "undefined type" exception that was being thrown when
+        selecting a eval script from the file menu in the Scripts panel.
+        This would also happen when stepping into an eval which would
+        break other parts of the Inspector interface.
+
+        Reviewed by Adam Roben.
+
+        * page/inspector/ScriptsPanel.js:
+        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
+        Use the scriptOrResource variable instead of the undefined script variable.
+
+2008-05-30  Timothy Hatcher  <timothy@apple.com>
+
         Made the starting line number of scripts be 1-based throughout the engine.
         This cleans up script line numbers so they are all consistent now and fixes
         some cases where script execution was shown as off by one line in the debugger.
index 9b74bab..ca37de1 100644 (file)
@@ -438,7 +438,7 @@ WebInspector.ScriptsPanel.prototype = {
 
         var option;
         if (scriptOrResource instanceof WebInspector.Script) {
-            option = script.filesSelectOption;
+            option = scriptOrResource.filesSelectOption;
             console.assert(option);
         } else {
             var url = scriptOrResource.url;