HTMLMediaElement: Remove two unnecessary virtual overrides.
authorakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 2 May 2014 00:04:19 +0000 (00:04 +0000)
committerakling@apple.com <akling@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 2 May 2014 00:04:19 +0000 (00:04 +0000)
<https://webkit.org/b/132445>

Now that ENABLE_PLUGIN_PROXY_FOR_VIDEO is gone, we can remove
these overrides:

    - defaultEventHandler()
    - willRespondToMouseClickEvents()

Reviewed by Darin Adler.

* html/HTMLMediaElement.cpp:
* html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLMediaElement.cpp
Source/WebCore/html/HTMLMediaElement.h

index b67f981..7230a0b 100644 (file)
@@ -1,3 +1,19 @@
+2014-05-01  Andreas Kling  <akling@apple.com>
+
+        HTMLMediaElement: Remove two unnecessary virtual overrides.
+        <https://webkit.org/b/132445>
+
+        Now that ENABLE_PLUGIN_PROXY_FOR_VIDEO is gone, we can remove
+        these overrides:
+
+            - defaultEventHandler()
+            - willRespondToMouseClickEvents()
+
+        Reviewed by Darin Adler.
+
+        * html/HTMLMediaElement.cpp:
+        * html/HTMLMediaElement.h:
+
 2014-05-01  Benjamin Poulain  <bpoulain@apple.com>
 
         ViewportConfiguration::minimumScale() uses the initial scale as initial value
index 8ff075a..e6f36cb 100644 (file)
@@ -4699,18 +4699,6 @@ void HTMLMediaElement::visibilityStateChanged()
 }
 #endif
 
-void HTMLMediaElement::defaultEventHandler(Event* event)
-{
-    HTMLElement::defaultEventHandler(event);
-}
-
-#if !PLATFORM(IOS)
-bool HTMLMediaElement::willRespondToMouseClickEvents()
-{
-    return HTMLElement::willRespondToMouseClickEvents();
-}
-#endif // !PLATFORM(IOS)
-
 #if ENABLE(VIDEO_TRACK)
 bool HTMLMediaElement::requiresTextTrackRepresentation() const
 {
index da97da8..7bee06a 100644 (file)
@@ -416,10 +416,6 @@ public:
     MediaController* controller() const;
     void setController(PassRefPtr<MediaController>);
 
-#if !PLATFORM(IOS)
-    virtual bool willRespondToMouseClickEvents() override;
-#endif
-
     void enteredOrExitedFullscreen() { configureMediaControls(); }
 
     unsigned long long fileSize() const;
@@ -483,8 +479,6 @@ private:
     virtual void removedFrom(ContainerNode&) override;
     virtual void didRecalcStyle(Style::Change) override;
 
-    virtual void defaultEventHandler(Event*) override;
-
     virtual void didBecomeFullscreenElement() override;
     virtual void willStopBeingFullscreenElement() override;