Unreviewed, rolling out r208837.
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 19 Nov 2016 04:25:38 +0000 (04:25 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 19 Nov 2016 04:25:38 +0000 (04:25 +0000)
The bots did not show a progression

Reverted changeset:

"REGRESSION(r208082): 1% Speedometer regression on iOS"
https://bugs.webkit.org/show_bug.cgi?id=164852
http://trac.webkit.org/changeset/208837

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@208917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/dom/CustomElementReactionQueue.cpp
Source/WebCore/dom/CustomElementReactionQueue.h

index d766631..fcfaa06 100644 (file)
@@ -1,3 +1,15 @@
+2016-11-18  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, rolling out r208837.
+
+        The bots did not show a progression
+
+        Reverted changeset:
+
+        "REGRESSION(r208082): 1% Speedometer regression on iOS"
+        https://bugs.webkit.org/show_bug.cgi?id=164852
+        http://trac.webkit.org/changeset/208837
+
 2016-11-18  Dean Jackson  <dino@apple.com>
 
         AX: "(inverted-colors)" media query only matches on page reload; should match on change
index 12c808d..12b6bad 100644 (file)
@@ -971,46 +971,6 @@ webkit.org/b/163706 imported/w3c/csswg-test/css-shapes-1/shape-outside/shape-ima
 imported/blink/http/tests/security/shape-image-cors-disallow-origin.html [ ImageOnlyFailure ]
 imported/blink/http/tests/security/shape-image-cors-port.html [ ImageOnlyFailure ]
 
-# Many custom Elements tests are temporarily skipped per https://webkit.org/b/164852
-fast/custom-elements/defined-pseudo-class.html [ Failure ]
-fast/custom-elements/reactions-for-indieui.html [ Failure ]
-fast/custom-elements/reactions-for-webkit-extensions.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/adopted-callback.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/connected-callbacks.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/custom-element-reaction-queue.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/disconnected-callbacks.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reaction-timing.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Attr.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/CSSStyleDeclaration.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ChildNode.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/DOMTokenList.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Document.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Element.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLAnchorElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOptionElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOptionsCollection.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOutputElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLSelectElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableRowElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableSectionElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTitleElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/NamedNodeMap.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Node.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ParentNode.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Range.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Selection.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ShadowRoot.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-enqueue-reactions.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html [ Failure ]
-
 webkit.org/b/163636 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Failure Timeout ]
 
 webkit.org/b/163887 svg/as-image/svg-image-with-data-uri-use-data-uri.svg [ Pass Crash ]
index 07555a2..5566d97 100644 (file)
@@ -1,3 +1,15 @@
+2016-11-18  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, rolling out r208837.
+
+        The bots did not show a progression
+
+        Reverted changeset:
+
+        "REGRESSION(r208082): 1% Speedometer regression on iOS"
+        https://bugs.webkit.org/show_bug.cgi?id=164852
+        http://trac.webkit.org/changeset/208837
+
 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
 
         Remove use of std::chrono in WebPage and entrained code
index a549ce6..07c5abe 100644 (file)
@@ -205,19 +205,26 @@ void CustomElementReactionQueue::invokeAll(Element& element)
 
 inline void CustomElementReactionStack::ElementQueue::add(Element& element)
 {
+    RELEASE_ASSERT(!m_invoking);
     // FIXME: Avoid inserting the same element multiple times.
     m_elements.append(element);
 }
 
 inline void CustomElementReactionStack::ElementQueue::invokeAll()
 {
+#if !ASSERT_DISABLED
+    RELEASE_ASSERT(!m_invoking);
+    TemporaryChange<bool> invoking(m_invoking, true);
+#endif
     Vector<Ref<Element>> elements;
     elements.swap(m_elements);
+    RELEASE_ASSERT(m_elements.isEmpty());
     for (auto& element : elements) {
         auto* queue = element->reactionQueue();
         ASSERT(queue);
         queue->invokeAll(element.get());
     }
+    RELEASE_ASSERT(m_elements.isEmpty());
 }
 
 CustomElementReactionQueue& CustomElementReactionStack::ensureCurrentQueue(Element& element)
index 906662c..0c9123d 100644 (file)
@@ -63,11 +63,16 @@ private:
 class CustomElementReactionStack {
 public:
     CustomElementReactionStack()
+        : m_previousProcessingStack(s_currentProcessingStack)
     {
+        s_currentProcessingStack = this;
     }
 
     ~CustomElementReactionStack()
     {
+        if (UNLIKELY(m_queue))
+            processQueue();
+        s_currentProcessingStack = m_previousProcessingStack;
     }
 
     static CustomElementReactionQueue& ensureCurrentQueue(Element&);
@@ -84,6 +89,7 @@ private:
 
     private:
         Vector<Ref<Element>> m_elements;
+        bool m_invoking { false };
     };
 
     WEBCORE_EXPORT void processQueue();
@@ -92,6 +98,7 @@ private:
     static ElementQueue& backupElementQueue();
 
     ElementQueue* m_queue { nullptr };
+    CustomElementReactionStack* m_previousProcessingStack;
 
     WEBCORE_EXPORT static CustomElementReactionStack* s_currentProcessingStack;
 };