LayoutTest webrtc/video-getParameters.html is failing
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Sep 2017 15:51:50 +0000 (15:51 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Sep 2017 15:51:50 +0000 (15:51 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170148

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-19
Reviewed by Alex Christensen.

* TestExpectations: Marking test as passing.
* webrtc/video-getParameters.html: Further sanitizing parameters against changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/webrtc/video-getParameters.html

index 272f0fd..d2024c2 100644 (file)
@@ -1,3 +1,13 @@
+2017-09-19  Youenn Fablet  <youenn@apple.com>
+
+        LayoutTest webrtc/video-getParameters.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=170148
+
+        Reviewed by Alex Christensen.
+
+        * TestExpectations: Marking test as passing.
+        * webrtc/video-getParameters.html: Further sanitizing parameters against changes.
+
 2017-09-19  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
 
         [GTK] The binding code of Media Source Extension of AudioTrack, VideoTrack and TextTrack is not generated
index ba291bb..a417399 100644 (file)
@@ -798,7 +798,6 @@ media/session [ Skip ]
 
 webrtc/datachannel/multiple-connections.html [ Slow ]
 webrtc/video-replace-track.html [ Pass Failure ]
-webrtc/video-getParameters.html [ Failure ]
 webkit.org/b/170178 webrtc/video-replace-track-to-null.html [ Pass Failure ]
 webkit.org/b/175305 webrtc/video-rotation.html [ Failure Timeout ]
 webkit.org/b/170704 webrtc/video-mute.html [ Failure ]
index 368eac7..c9c949f 100644 (file)
@@ -40,10 +40,13 @@ promise_test((test) => {
         assert_true(!!senderParameters, "sender parameters should not be undefined or null");
         assert_true(!!receiverParameters, "receiver parameters should not be undefined or null");
 
-        assert_equals(JSON.stringify(senderParameters), JSON.stringify(receiverParameters), "testing sender vs. receiver parameters");
-
         senderParameters.encodings[0].fec.ssrc = 1;
         senderParameters.encodings[0].rtx.ssrc = 1;
+        receiverParameters.encodings[0].fec.ssrc = 1;
+        receiverParameters.encodings[0].rtx.ssrc = 1;
+
+        assert_equals(JSON.stringify(senderParameters), JSON.stringify(receiverParameters), "testing sender vs. receiver parameters");
+
         senderParameters.encodings[0].ssrc = 1;
         assert_equals(JSON.stringify(senderParameters), '{"codecs":[],"degradationPreference":"balanced","encodings":[{"active":true,"dtx":"disabled","fec":{"ssrc":1},"maxBitrate":0,"maxFramerate":0,"priority":"medium","rid":"","rtx":{"ssrc":1},"scaleResolutionDownBy":1,"ssrc":1}],"headerExtensions":[],"transactionId":""}', "Testing sanitized parameters");
     });