REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Oct 2016 18:08:16 +0000 (18:08 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Oct 2016 18:08:16 +0000 (18:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=163583
<rdar://problem/28815882>

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-10-18
Reviewed by Timothy Hatcher.

* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
Revert logic change introduced by r201171 with no explanation.
Whenever we get a start time we should use it, regardless of
of what the current time is, precisely because the backend is
informing us of the start time to use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@207473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

index 79d41bf..1b24ec7 100644 (file)
@@ -1,3 +1,18 @@
+2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
+
+        REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
+        https://bugs.webkit.org/show_bug.cgi?id=163583
+        <rdar://problem/28815882>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
+        Revert logic change introduced by r201171 with no explanation.
+        Whenever we get a start time we should use it, regardless of
+        of what the current time is, precisely because the backend is
+        informing us of the start time to use.
+
 2016-10-17  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Add toggles for debugger pauses at console.assert failures
index e804b71..12ccb41 100644 (file)
@@ -439,9 +439,9 @@ WebInspector.TimelineRecordingContentView = class TimelineRecordingContentView e
         if (!WebInspector.visible)
             return;
 
-        if (typeof startTime === "number" && !isNaN(this._currentTime))
+        if (typeof startTime === "number")
             this._currentTime = startTime;
-        else {
+        else if (!isNaN(this._currentTime)) {
             // This happens when you stop and later restart recording.
             // COMPATIBILITY (iOS 9): Timeline.recordingStarted events did not include a timestamp.
             // We likely need to jump into the future to a better current time which we can