Do not set WebAVPlayerLayerView background to black in fullscreen.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Apr 2017 19:35:26 +0000 (19:35 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 3 Apr 2017 19:35:26 +0000 (19:35 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170132
rdar://problem/30839278

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-04-03
Reviewed by Tim Horton.

No new tests because no behavior change.

The black background on WebAVPlayerLayerView interferes with the fullscreen animation
and has been removed.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

index 2875e4d..0fa1da4 100644 (file)
@@ -1,3 +1,20 @@
+2017-04-03  Jeremy Jones  <jeremyj@apple.com>
+
+        Do not set WebAVPlayerLayerView background to black in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=170132
+        rdar://problem/30839278
+
+        Reviewed by Tim Horton.
+
+        No new tests because no behavior change.
+
+        The black background on WebAVPlayerLayerView interferes with the fullscreen animation
+        and has been removed.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::enterFullscreen):
+        (WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard):
+
 2017-04-03  Antti Koivisto  <antti@apple.com>
 
         REGRESSION (r207669): FileMaker Pro Help pages do not render correctly
index aad41f0..18d9a0f 100644 (file)
@@ -668,7 +668,6 @@ void WebVideoFullscreenInterfaceAVKit::enterFullscreen()
     m_exitRequested = false;
     m_enterRequested = true;
 
-    [m_playerLayerView setBackgroundColor:[getUIColorClass() blackColor]];
     if (mode() == HTMLMediaElementEnums::VideoFullscreenModePictureInPicture)
         enterPictureInPicture();
     else if (mode() == HTMLMediaElementEnums::VideoFullscreenModeStandard)
@@ -699,7 +698,6 @@ void WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard()
         return;
     }
 
-    [m_playerLayerView setBackgroundColor:[getUIColorClass() blackColor]];
     [m_playerViewController enterFullScreenAnimated:YES completionHandler:[this, protectedThis] (BOOL succeeded, NSError*) {
         UNUSED_PARAM(succeeded);
         LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::enterFullscreenStandard - lambda(%p) - succeeded(%s)", this, boolString(succeeded));