Enable regenerateStructNames workaround on iOS
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 May 2020 01:54:09 +0000 (01:54 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 May 2020 01:54:09 +0000 (01:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=212056

Patch by James Darpinian <jdarpinian@chromium.org> on 2020-05-18
Reviewed by Dean Jackson.

The WebGL conformance test conformance/glsl/misc/shader-struct-scope.html
was failing on iOS. The workaround that fixes this test was enabled only on
desktop GL, but it's necessary for iOS as well.

* src/libANGLE/renderer/gl/renderergl_utils.cpp:
(rx::nativegl_gl::InitializeFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@261844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/ThirdParty/ANGLE/ChangeLog
Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/renderergl_utils.cpp

index 211fc97..a0e017d 100644 (file)
@@ -1,3 +1,17 @@
+2020-05-18  James Darpinian  <jdarpinian@chromium.org>
+
+        Enable regenerateStructNames workaround on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=212056
+
+        Reviewed by Dean Jackson.
+
+        The WebGL conformance test conformance/glsl/misc/shader-struct-scope.html
+        was failing on iOS. The workaround that fixes this test was enabled only on
+        desktop GL, but it's necessary for iOS as well.
+
+        * src/libANGLE/renderer/gl/renderergl_utils.cpp:
+        (rx::nativegl_gl::InitializeFeatures):
+
 2020-05-14  James Darpinian  <jdarpinian@chromium.org>
 
         REGRESSION (r259589): Google Maps background layer fades out and back in
index 6a250db..a14e542 100644 (file)
@@ -1653,8 +1653,7 @@ void InitializeFeatures(const FunctionsGL *functions, angle::FeaturesGL *feature
                             IsApple() || IsAndroid() || IsWindows());
 
     // Ported from gpu_driver_bug_list.json (#89)
-    ANGLE_FEATURE_CONDITION(features, regenerateStructNames,
-                            IsApple() && functions->standard == STANDARD_GL_DESKTOP);
+    ANGLE_FEATURE_CONDITION(features, regenerateStructNames, IsApple());
 
     // Ported from gpu_driver_bug_list.json (#184)
     ANGLE_FEATURE_CONDITION(features, preAddTexelFetchOffsets, IsApple() && isIntel);