Rebaseline and enable media/modern-media-controls/fullscreen-button
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Jun 2017 18:56:17 +0000 (18:56 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Jun 2017 18:56:17 +0000 (18:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=173101

Reviewed by Dean Jackson.

Update the test to check an SVG asset now that we use those.

* media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt:
* media/modern-media-controls/fullscreen-button/fullscreen-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt
LayoutTests/media/modern-media-controls/fullscreen-button/fullscreen-button.html
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/mac/TestExpectations

index 96ed57e..46f63b4 100644 (file)
@@ -1,5 +1,19 @@
 2017-06-08  Antoine Quint  <graouts@apple.com>
 
+        Rebaseline and enable media/modern-media-controls/fullscreen-button
+        https://bugs.webkit.org/show_bug.cgi?id=173101
+
+        Reviewed by Dean Jackson.
+
+        Update the test to check an SVG asset now that we use those.
+
+        * media/modern-media-controls/fullscreen-button/fullscreen-button-expected.txt:
+        * media/modern-media-controls/fullscreen-button/fullscreen-button.html:
+        * platform/ios-simulator/TestExpectations:
+        * platform/mac/TestExpectations:
+
+2017-06-08  Antoine Quint  <graouts@apple.com>
+
         Rebaseline and enable media/modern-media-controls/forward-button
         https://bugs.webkit.org/show_bug.cgi?id=173100
 
index 026ea43..bd1ccc7 100644 (file)
@@ -4,13 +4,12 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 
 PASS enterFullscreenButton.element.localName is "button"
-PASS enterFullscreenButton.element.classList.contains("icon") is true
 PASS enterFullscreenButton.element.classList.contains("fullscreen") is true
 PASS enterFullscreenButton.iconName is Icons.EnterFullscreen
 PASS exitFullscreenButton.iconName is Icons.ExitFullscreen
-PASS enterFullscreenButton.element.style.webkitMaskImage.includes("macOS/enter-fullscreen@") is true
-PASS iOSEnterFullscreenButton.element.style.webkitMaskImage.includes("iOS/enter-fullscreen@") is true
-PASS exitFullscreenButton.element.style.webkitMaskImage.includes("macOS/exit-fullscreen@") is true
+PASS enterFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/EnterFullscreen.svg") is true
+PASS iOSEnterFullscreenButton.image.element.style.webkitMaskImage.includes("iOS/EnterFullscreen.svg") is true
+PASS exitFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/ExitFullscreen.svg") is true
 PASS successfullyParsed is true
 
 TEST COMPLETE
index a924b68..60331e4 100644 (file)
@@ -11,7 +11,6 @@ description("Testing the <code>FullscreenButton</code> class.");
 const enterFullscreenButton = new FullscreenButton({ layoutTraits: LayoutTraits.macOS });
 
 shouldBeEqualToString("enterFullscreenButton.element.localName", "button");
-shouldBeTrue('enterFullscreenButton.element.classList.contains("icon")');
 shouldBeTrue('enterFullscreenButton.element.classList.contains("fullscreen")');
 shouldBe("enterFullscreenButton.iconName", "Icons.EnterFullscreen");
 
@@ -25,9 +24,9 @@ scheduler.frameDidFire = function()
     if ([enterFullscreenButton, iOSEnterFullscreenButton, exitFullscreenButton].some(button => button.width == 0))
         return;
 
-    shouldBeTrue('enterFullscreenButton.element.style.webkitMaskImage.includes("macOS/enter-fullscreen@")');
-    shouldBeTrue('iOSEnterFullscreenButton.element.style.webkitMaskImage.includes("iOS/enter-fullscreen@")');
-    shouldBeTrue('exitFullscreenButton.element.style.webkitMaskImage.includes("macOS/exit-fullscreen@")');
+    shouldBeTrue('enterFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/EnterFullscreen.svg")');
+    shouldBeTrue('iOSEnterFullscreenButton.image.element.style.webkitMaskImage.includes("iOS/EnterFullscreen.svg")');
+    shouldBeTrue('exitFullscreenButton.image.element.style.webkitMaskImage.includes("macOS/ExitFullscreen.svg")');
     finishMediaControlsTest();
 };
 
index a09e52f..259d3ba 100644 (file)
@@ -63,6 +63,7 @@ media/modern-media-controls/button [ Pass ]
 media/modern-media-controls/buttons-container [ Pass ]
 media/modern-media-controls/controls-visibility-support [ Pass ]
 media/modern-media-controls/forward-button [ Pass ]
+media/modern-media-controls/fullscreen-button [ Pass ]
 
 # AirPlay cannot be tested on iOS
 webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
index 1d2141e..0bae572 100644 (file)
@@ -1558,6 +1558,7 @@ media/modern-media-controls/button [ Pass ]
 media/modern-media-controls/buttons-container [ Pass ]
 media/modern-media-controls/controls-visibility-support [ Pass ]
 media/modern-media-controls/forward-button [ Pass ]
+media/modern-media-controls/fullscreen-button [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
 media/modern-media-controls/volume-up-support [ Pass ]