Unreviewed, rolling out r121178.
authorhclam@chromium.org <hclam@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Jun 2012 22:45:39 +0000 (22:45 +0000)
committerhclam@chromium.org <hclam@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 25 Jun 2012 22:45:39 +0000 (22:45 +0000)
http://trac.webkit.org/changeset/121178
https://bugs.webkit.org/show_bug.cgi?id=89784

New unit test added is failing on WebKit Linux (dbg)

Source/WebCore:

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):

Source/WebKit/chromium:

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/chromium/LayerChromium.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/tests/LayerChromiumTest.cpp

index 4d2c208..6961277 100644 (file)
@@ -1,5 +1,16 @@
 2012-06-25  Alpha Lam  <hclam@chromium.org>
 
+        Unreviewed, rolling out r121178.
+        http://trac.webkit.org/changeset/121178
+        https://bugs.webkit.org/show_bug.cgi?id=89784
+
+        New unit test added is failing on WebKit Linux (dbg)
+
+        * platform/graphics/chromium/LayerChromium.cpp:
+        (WebCore::LayerChromium::setBounds):
+
+2012-06-25  Alpha Lam  <hclam@chromium.org>
+
         Unreviewed, rolling out r121137.
         http://trac.webkit.org/changeset/121137
 
index 1a4038a..5aed1c7 100644 (file)
@@ -228,7 +228,7 @@ void LayerChromium::setBounds(const IntSize& size)
     if (bounds() == size)
         return;
 
-    bool firstResize = bounds().isEmpty() && !size.isEmpty();
+    bool firstResize = !bounds().width() && !bounds().height() && size.width() && size.height();
 
     m_bounds = size;
 
index 3b39f69..9d60e49 100644 (file)
@@ -1,5 +1,15 @@
 2012-06-25  Alpha Lam  <hclam@chromium.org>
 
+        Unreviewed, rolling out r121178.
+        http://trac.webkit.org/changeset/121178
+        https://bugs.webkit.org/show_bug.cgi?id=89784
+
+        New unit test added is failing on WebKit Linux (dbg)
+
+        * tests/LayerChromiumTest.cpp:
+
+2012-06-25  Alpha Lam  <hclam@chromium.org>
+
         Unreviewed, rolling out r121129.
         http://trac.webkit.org/changeset/121129
         https://bugs.webkit.org/show_bug.cgi?id=89542
index 38fb81c..cd4fcc3 100644 (file)
@@ -813,20 +813,4 @@ TEST(LayerChromiumLayerTreeHostTest, replaceMaskAndReplicaLayer)
     WebKit::WebCompositor::shutdown();
 }
 
-class MockLayerChromium : public LayerChromium {
-public:
-    bool needsDisplay() const { return m_needsDisplay; }
-};
-
-TEST(LayerChromiumTestWithoutFixture, setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds)
-{
-    MockLayerChromium layer;
-    EXPECT_FALSE(layer.needsDisplay());
-    layer.setBounds(IntSize(0, 10));
-    EXPECT_FALSE(layer.needsDisplay());
-    layer.setBounds(IntSize(10, 10));
-    EXPECT_TRUE(layer.needsDisplay());
-}
-
-
 } // namespace