2010-04-21 Ojan Vafai <ojan@chromium.org>
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Apr 2010 20:50:17 +0000 (20:50 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Apr 2010 20:50:17 +0000 (20:50 +0000)
        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
        * platform/mac/fast/repaint/stacked-diacritics-expected.png:
2010-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adele Peterson.

        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
        https://bugs.webkit.org/show_bug.cgi?id=37292

        #if out the canUseGlyphCache Changes from r57215 as they caused a
        8% perf regression on Chromium's international page load tests so that
        the perf regression can be fixed properly without being left in the tree.

        * platform/graphics/FontFastPath.cpp:
        (WebCore::Font::canUseGlyphCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac/fast/repaint/stacked-diacritics-expected.checksum
LayoutTests/platform/mac/fast/repaint/stacked-diacritics-expected.png
WebCore/ChangeLog
WebCore/platform/graphics/FontFastPath.cpp

index 854c1be..67a0319 100644 (file)
@@ -1,3 +1,17 @@
+2010-04-21  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adele Peterson.
+
+        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
+        https://bugs.webkit.org/show_bug.cgi?id=37292
+
+        #if out the canUseGlyphCache Changes from r57215 as they caused a 
+        8% perf regression on Chromium's international page load tests so that
+        the perf regression can be fixed properly without being left in the tree.
+
+        * platform/mac/fast/repaint/stacked-diacritics-expected.checksum:
+        * platform/mac/fast/repaint/stacked-diacritics-expected.png:
+
 2010-04-28  Alexey Proskuryakov  <ap@apple.com>
 
         Reviewed by David Kilzer.
index 0426bbc..f5aad2b 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/repaint/stacked-diacritics-expected.png and b/LayoutTests/platform/mac/fast/repaint/stacked-diacritics-expected.png differ
index 19a318c..c834ca6 100644 (file)
@@ -1,3 +1,17 @@
+2010-04-21  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Adele Peterson.
+
+        http://trac.webkit.org/changeset/57215 caused perf/memory regressions
+        https://bugs.webkit.org/show_bug.cgi?id=37292
+
+        #if out the canUseGlyphCache Changes from r57215 as they caused a 
+        8% perf regression on Chromium's international page load tests so that
+        the perf regression can be fixed properly without being left in the tree.
+
+        * platform/graphics/FontFastPath.cpp:
+        (WebCore::Font::canUseGlyphCache):
+
 2010-04-28  Beth Dakin  <bdakin@apple.com>
 
         Reviewed by Darin Adler.
index 6e2a744..7dac717 100644 (file)
 #include <wtf/MathExtras.h>
 #include <wtf/unicode/Unicode.h>
 
+#ifndef ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE
+#define ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE 1
+#endif
+
 using namespace WTF;
 using namespace Unicode;
 
@@ -234,12 +238,13 @@ bool Font::canUseGlyphCache(const TextRun& run) const
         if (c <= 0x194F)
             return false;
 
+#if !ROMAN_AND_GREEK_DIACRITICS_CAN_USE_GLYPH_CACHE
         // FIXME: we should not use complex text path for these characters.
-        
         if (c < 0x1E00)     // U+1E00 through U+2000 characters with diacritics and stacked diacritics
             continue;
         if (c <= 0x2000)
             return false;
+#endif
 
         if (c < 0x20D0)     // U+20D0 through U+20FF Combining marks for symbols
             continue;