Sample domainsVisited diagnostic logging
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Feb 2019 00:36:06 +0000 (00:36 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Feb 2019 00:36:06 +0000 (00:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194657

Reviewed by Ryosuke Niwa.

Sample domainsVisited diagnostic logging, we are getting a lot of data from
this key and this is hurting our other keys.

* page/Page.cpp:
(WebCore::Page::logNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/Page.cpp

index 06bd2d0..e1735f0 100644 (file)
@@ -1,3 +1,16 @@
+2019-02-15  Chris Dumez  <cdumez@apple.com>
+
+        Sample domainsVisited diagnostic logging
+        https://bugs.webkit.org/show_bug.cgi?id=194657
+
+        Reviewed by Ryosuke Niwa.
+
+        Sample domainsVisited diagnostic logging, we are getting a lot of data from
+        this key and this is hurting our other keys.
+
+        * page/Page.cpp:
+        (WebCore::Page::logNavigation):
+
 2019-02-15  Ryosuke Niwa  <rniwa@webkit.org>
 
         Crash in the hit testing code via HTMLPlugInElement::isReplacementObscured()
index 690735d..b02688a 100644 (file)
@@ -2369,7 +2369,7 @@ void Page::logNavigation(const Navigation& navigation)
     diagnosticLoggingClient().logDiagnosticMessage(DiagnosticLoggingKeys::navigationKey(), navigationDescription, ShouldSample::No);
 
     if (!navigation.domain.isEmpty())
-        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No);
+        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes);
 }
 
 void Page::mainFrameLoadStarted(const URL& destinationURL, FrameLoadType type)