WebCore headers should not be included relatively within dependent projects
authordon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Feb 2018 18:42:02 +0000 (18:42 +0000)
committerdon.olmstead@sony.com <don.olmstead@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Feb 2018 18:42:02 +0000 (18:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=182805

Reviewed by Chris Dumez.

Source/WebKit:

* NetworkProcess/capture/NetworkCaptureManager.cpp:
* NetworkProcess/webrtc/NetworkRTCMonitor.h:
* Shared/gtk/WebEventFactory.cpp:
* UIProcess/API/gtk/PageClientImpl.cpp:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
* UIProcess/gtk/WebPageProxyGtk.cpp:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
* WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
* WebProcess/WebPage/wpe/WebPageWPE.cpp:

Source/WebKitLegacy/win:

* FullscreenVideoController.h:

Tools:

* TestWebKitAPI/win/TestWebCoreStubs.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
* WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
* WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21 files changed:
Source/WebKit/ChangeLog
Source/WebKit/NetworkProcess/capture/NetworkCaptureManager.cpp
Source/WebKit/NetworkProcess/webrtc/NetworkRTCMonitor.h
Source/WebKit/Shared/gtk/WebEventFactory.cpp
Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
Source/WebKit/UIProcess/gtk/WebPageProxyGtk.cpp
Source/WebKit/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp
Source/WebKit/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp
Source/WebKit/WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp
Source/WebKit/WebProcess/WebPage/gtk/WebPageGtk.cpp
Source/WebKit/WebProcess/WebPage/wpe/WebPageWPE.cpp
Source/WebKitLegacy/win/ChangeLog
Source/WebKitLegacy/win/FullscreenVideoController.h
Tools/ChangeLog
Tools/TestWebKitAPI/win/TestWebCoreStubs.cpp
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp
Tools/WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp
Tools/WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp
Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp

index fa0fa26..05166ea 100644 (file)
@@ -1,3 +1,22 @@
+2018-02-15  Don Olmstead  <don.olmstead@sony.com>
+
+        WebCore headers should not be included relatively within dependent projects
+        https://bugs.webkit.org/show_bug.cgi?id=182805
+
+        Reviewed by Chris Dumez.
+
+        * NetworkProcess/capture/NetworkCaptureManager.cpp:
+        * NetworkProcess/webrtc/NetworkRTCMonitor.h:
+        * Shared/gtk/WebEventFactory.cpp:
+        * UIProcess/API/gtk/PageClientImpl.cpp:
+        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+        * UIProcess/gtk/WebPageProxyGtk.cpp:
+        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+        * WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
+        * WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:
+        * WebProcess/WebPage/gtk/WebPageGtk.cpp:
+        * WebProcess/WebPage/wpe/WebPageWPE.cpp:
+
 2018-02-15  Matt Lewis  <jlewis3@apple.com>
 
         Unreviewed, rolling out r228495.
index d3ce252..5613be8 100644 (file)
@@ -30,8 +30,8 @@
 
 #include "NetworkCaptureLogging.h"
 #include "NetworkCaptureResource.h"
-#include "WebCore/ResourceRequest.h"
-#include "WebCore/URL.h"
+#include <WebCore/ResourceRequest.h>
+#include <WebCore/URL.h>
 #include <algorithm>
 #include <iterator>
 #include <limits>
index 14882cd..33cc73b 100644 (file)
@@ -27,7 +27,7 @@
 
 #if USE(LIBWEBRTC)
 
-#include "WebCore/LibWebRTCMacros.h"
+#include <WebCore/LibWebRTCMacros.h>
 #include <webrtc/base/network.h>
 #include <webrtc/base/sigslot.h>
 #include <webrtc/base/thread.h>
index 8be918b..dd94e19 100644 (file)
 #include "config.h"
 #include "WebEventFactory.h"
 
-#include "PlatformKeyboardEvent.h"
-#include "Scrollbar.h"
-#include "WindowsKeyboardCodes.h"
 #include <WebCore/GtkUtilities.h>
 #include <WebCore/GtkVersioning.h>
+#include <WebCore/PlatformKeyboardEvent.h>
+#include <WebCore/Scrollbar.h>
+#include <WebCore/WindowsKeyboardCodes.h>
 #include <gdk/gdk.h>
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
index 6d465a5..3ed5be9 100644 (file)
@@ -32,7 +32,6 @@
 #include "NativeWebKeyboardEvent.h"
 #include "NativeWebMouseEvent.h"
 #include "NativeWebWheelEvent.h"
-#include "NotImplemented.h"
 #include "WebColorPickerGtk.h"
 #include "WebContextMenuProxyGtk.h"
 #include "WebEventFactory.h"
@@ -46,6 +45,7 @@
 #include <WebCore/Cursor.h>
 #include <WebCore/EventNames.h>
 #include <WebCore/GtkUtilities.h>
+#include <WebCore/NotImplemented.h>
 #include <WebCore/RefPtrCairo.h>
 #include <wtf/Compiler.h>
 #include <wtf/text/CString.h>
index f339a40..8c1436f 100644 (file)
@@ -31,7 +31,6 @@
 
 #include "APIPageConfiguration.h"
 #include "AcceleratedBackingStore.h"
-#include "ActivityState.h"
 #include "DrawingAreaProxyImpl.h"
 #include "InputMethodFilter.h"
 #include "KeyBindingTranslator.h"
@@ -50,6 +49,7 @@
 #include "WebPreferences.h"
 #include "WebProcessPool.h"
 #include "WebUserContentControllerProxy.h"
+#include <WebCore/ActivityState.h>
 #include <WebCore/CairoUtilities.h>
 #include <WebCore/GUniquePtrGtk.h>
 #include <WebCore/GtkUtilities.h>
index 962e838..94cd84c 100644 (file)
 #include "config.h"
 #include "WebPageProxy.h"
 
-#include "NotImplemented.h"
 #include "PageClientImpl.h"
 #include "WebKitWebViewBasePrivate.h"
 #include "WebPageMessages.h"
 #include "WebPasteboardProxy.h"
 #include "WebProcessProxy.h"
 #include "WebsiteDataStore.h"
+#include <WebCore/NotImplemented.h>
 #include <WebCore/PlatformDisplay.h>
 #include <WebCore/UserAgent.h>
 #include <gtk/gtkx.h>
index 6d7c9bd..3a6d66c 100644 (file)
@@ -47,8 +47,8 @@
 #endif
 
 #if USE(CAIRO)
-#include "PlatformContextCairo.h"
-#include "RefPtrCairo.h"
+#include <WebCore/PlatformContextCairo.h>
+#include <WebCore/RefPtrCairo.h>
 #include <cairo/cairo-xlib.h>
 #endif
 
index d579178..bcaa211 100644 (file)
 #include "config.h"
 #include "WebEditorClient.h"
 
-#include "PlatformKeyboardEvent.h"
 #include <WebCore/Document.h>
 #include <WebCore/Editor.h>
 #include <WebCore/EventNames.h>
 #include <WebCore/Frame.h>
 #include <WebCore/KeyboardEvent.h>
 #include <WebCore/Pasteboard.h>
+#include <WebCore/PlatformKeyboardEvent.h>
 #include <WebCore/markup.h>
 #include <wtf/glib/GRefPtr.h>
 
index 4801cd3..b05b865 100644 (file)
 #include "config.h"
 #include "WebEditorClient.h"
 
-#include "PlatformKeyboardEvent.h"
 #include <WebCore/Document.h>
 #include <WebCore/Editor.h>
 #include <WebCore/EventNames.h>
 #include <WebCore/Frame.h>
 #include <WebCore/KeyboardEvent.h>
 #include <WebCore/Node.h>
+#include <WebCore/PlatformKeyboardEvent.h>
 #include <WebCore/WindowsKeyboardCodes.h>
 #include <wtf/NeverDestroyed.h>
 
index 6c0cae7..493cb16 100644 (file)
 #include "WebPage.h"
 
 #include "EditorState.h"
-#include "NotImplemented.h"
 #include "WebEvent.h"
 #include "WebFrame.h"
 #include "WebPageAccessibilityObject.h"
 #include "WebPageProxyMessages.h"
 #include "WebProcess.h"
-#include "WindowsKeyboardCodes.h"
 #include <WebCore/BackForwardController.h>
 #include <WebCore/Editor.h>
 #include <WebCore/EventHandler.h>
 #include <WebCore/Frame.h>
 #include <WebCore/FrameView.h>
 #include <WebCore/KeyboardEvent.h>
+#include <WebCore/NotImplemented.h>
 #include <WebCore/Page.h>
 #include <WebCore/PasteboardHelper.h>
 #include <WebCore/PlatformKeyboardEvent.h>
 #include <WebCore/Settings.h>
 #include <WebCore/SharedBuffer.h>
 #include <WebCore/UserAgent.h>
+#include <WebCore/WindowsKeyboardCodes.h>
 #include <wtf/glib/GUniquePtr.h>
 
 namespace WebKit {
index cdd73bb..2f4ab94 100644 (file)
@@ -26,9 +26,9 @@
 #include "config.h"
 #include "WebPage.h"
 
-#include "NotImplemented.h"
 #include "WebPreferencesKeys.h"
 #include "WebPreferencesStore.h"
+#include <WebCore/NotImplemented.h>
 #include <WebCore/Settings.h>
 #include <WebCore/SharedBuffer.h>
 
index 899ba34..7dbd11a 100644 (file)
@@ -1,3 +1,12 @@
+2018-02-15  Don Olmstead  <don.olmstead@sony.com>
+
+        WebCore headers should not be included relatively within dependent projects
+        https://bugs.webkit.org/show_bug.cgi?id=182805
+
+        Reviewed by Chris Dumez.
+
+        * FullscreenVideoController.h:
+
 2018-02-13  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r228431.
index 4df74c1..f1de8dd 100644 (file)
 
 #if ENABLE(VIDEO)
 
-#include "MediaPlayerPrivateFullscreenWindow.h"
-
 #include <WebCore/HTMLVideoElement.h>
 #include <WebCore/Image.h>
 #include <WebCore/IntPoint.h>
 #include <WebCore/IntSize.h>
+#include <WebCore/MediaPlayerPrivateFullscreenWindow.h>
 #include <wtf/RefPtr.h>
 #include <wtf/win/GDIObject.h>
 
index 02fe19e..c8e399c 100644 (file)
@@ -1,3 +1,17 @@
+2018-02-15  Don Olmstead  <don.olmstead@sony.com>
+
+        WebCore headers should not be included relatively within dependent projects
+        https://bugs.webkit.org/show_bug.cgi?id=182805
+
+        Reviewed by Chris Dumez.
+
+        * TestWebKitAPI/win/TestWebCoreStubs.cpp:
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+        * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp:
+        * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
+        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+        * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
+
 2018-02-15  Tomas Popela  <tpopela@redhat.com>
 
         run-jsc-stress-tests - skip a test if any of the run commands evals to skip
index 1f930f2..46c7620 100644 (file)
@@ -23,7 +23,7 @@
  */
 #include "config.h"
 
-#include "SharedBuffer.h"
+#include <WebCore/SharedBuffer.h>
 
 RefPtr<WebCore::SharedBuffer> loadResourceIntoBuffer(const char*)
 {
index 66a8b4e..4b2b82d 100644 (file)
@@ -32,9 +32,9 @@
 
 #include "InjectedBundle.h"
 #include "InjectedBundlePage.h"
-#include "NotImplemented.h"
 #include <JavaScriptCore/JSStringRef.h>
 #include <JavaScriptCore/OpaqueJSString.h>
+#include <WebCore/NotImplemented.h>
 #if ATK_CHECK_VERSION(2,11,90)
 #include <WebKit/WKBundleFrame.h>
 #endif
index 378141d..6b916df 100644 (file)
@@ -33,9 +33,9 @@
 #include "config.h"
 #include "EventSenderProxy.h"
 
-#include "NotImplemented.h"
 #include "PlatformWebView.h"
 #include "TestController.h"
+#include <WebCore/NotImplemented.h>
 #include <gdk/gdkkeysyms.h>
 #include <gtk/gtk.h>
 #include <wtf/StdLibExtras.h>
index b271188..c2c8be1 100644 (file)
@@ -27,9 +27,9 @@
 #include "EventSenderProxy.h"
 
 #include "HeadlessViewBackend.h"
-#include "NotImplemented.h"
 #include "PlatformWebView.h"
 #include "TestController.h"
+#include <WebCore/NotImplemented.h>
 #include <wpe/view-backend.h>
 #include <xkbcommon/xkbcommon-keysyms.h>
 #include <xkbcommon/xkbcommon.h>