2011-04-12 Kent Tamura <tkent@chromium.org>
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Apr 2011 05:47:47 +0000 (05:47 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Apr 2011 05:47:47 +0000 (05:47 +0000)
        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * platform/chromium/test_expectations.txt:
          Remove validation-message-appearance.html because it becomes non-flaky
          by the DRT change.
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * public/WebSettings.h: Declare new function.
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
         Passing the specified value to WebCore::Settings.
        * src/WebSettingsImpl.h: Declare new function.
2011-04-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
        https://bugs.webkit.org/show_bug.cgi?id=57426

        * DumpRenderTree/chromium/WebPreferences.cpp:
        (WebPreferences::applyTo): Disable the validation message timer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium/test_expectations.txt
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/public/WebSettings.h
Source/WebKit/chromium/src/WebSettingsImpl.cpp
Source/WebKit/chromium/src/WebSettingsImpl.h
Tools/ChangeLog
Tools/DumpRenderTree/chromium/WebPreferences.cpp

index 253eb96..d5c580f 100644 (file)
@@ -1,3 +1,14 @@
+2011-04-12  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
+        https://bugs.webkit.org/show_bug.cgi?id=57426
+
+        * platform/chromium/test_expectations.txt:
+          Remove validation-message-appearance.html because it becomes non-flaky
+          by the DRT change.
+
 2011-04-12  Sergey Glazunov  <serg.glazunov@gmail.com>
 
         Reviewed by Dimitri Glazkov.
index 59f6b06..b6ecaca 100644 (file)
@@ -785,9 +785,6 @@ BUGCR20226 : fast/forms/datalist.html = TEXT
 BUGCR20226 : fast/forms/input-list.html = FAIL
 BUGCR20226 : fast/forms/input-selectedoption.html = FAIL
 
-// Needs to call Settings::setValidationMessageTimerMagnification(-1).
-BUGWK57290 : fast/forms/validation-message-appearance.html = PASS FAIL
-
 // Timing out.
 BUGCR78376 SKIP : http/tests/media/video-play-stall-seek.html = TIMEOUT
 
index 17d350e..0ca9d66 100644 (file)
@@ -1,3 +1,16 @@
+2011-04-12  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
+        https://bugs.webkit.org/show_bug.cgi?id=57426
+
+        * public/WebSettings.h: Declare new function.
+        * src/WebSettingsImpl.cpp:
+        (WebKit::WebSettingsImpl::setValidationMessageTimerMagnification):
+         Passing the specified value to WebCore::Settings.
+        * src/WebSettingsImpl.h: Declare new function.
+
 2011-04-12  Antoine Labour  <piman@chromium.org>
 
         Reviewed by Kenneth Russell.
index 56032c1..ed4e6ef 100644 (file)
@@ -116,6 +116,7 @@ public:
     virtual void setAsynchronousSpellCheckingEnabled(bool) = 0;
     virtual void setCaretBrowsingEnabled(bool) = 0;
     virtual void setInteractiveFormValidationEnabled(bool) = 0;
+    virtual void setValidationMessageTimerMagnification(int) = 0;
     virtual void setMinimumTimerInterval(double) = 0;
     virtual void setFullScreenEnabled(bool) = 0;
 
index 73cc7c5..c5b60cc 100644 (file)
@@ -378,6 +378,11 @@ void WebSettingsImpl::setInteractiveFormValidationEnabled(bool enabled)
     m_settings->setInteractiveFormValidationEnabled(enabled);
 }
 
+void WebSettingsImpl::setValidationMessageTimerMagnification(int newValue)
+{
+    m_settings->setValidationMessageTimerMagnification(newValue);
+}
+
 void WebSettingsImpl::setMinimumTimerInterval(double interval)
 {
     m_settings->setMinDOMTimerInterval(interval);
index 798a78f..57aa804 100644 (file)
@@ -109,6 +109,7 @@ public:
     virtual void setAsynchronousSpellCheckingEnabled(bool);
     virtual void setCaretBrowsingEnabled(bool);
     virtual void setInteractiveFormValidationEnabled(bool);
+    virtual void setValidationMessageTimerMagnification(int);
     virtual void setMinimumTimerInterval(double);
     virtual void setFullScreenEnabled(bool);
 
index a8c2ef5..a81af3b 100644 (file)
@@ -1,3 +1,13 @@
+2011-04-12  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
+        https://bugs.webkit.org/show_bug.cgi?id=57426
+
+        * DumpRenderTree/chromium/WebPreferences.cpp:
+        (WebPreferences::applyTo): Disable the validation message timer.
+
 2011-04-12  James Kozianski  <koz@chromium.org>
 
         Unreviewed.
index 5783bdc..c609397 100644 (file)
@@ -165,8 +165,8 @@ void WebPreferences::applyTo(WebView* webView)
     settings->setUsesEncodingDetector(false);
     settings->setImagesEnabled(true);
     settings->setInteractiveFormValidationEnabled(true);
-
     // Enable fullscreen so the fullscreen layout tests can run.
     settings->setFullScreenEnabled(true);
+    settings->setValidationMessageTimerMagnification(-1);
 }