REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key...

https://bugs.webkit.org/show_bug.cgi?id=191642

Reviewed by Zalan Bujtas.

Source/WebCore:

Invalidate access key map even when thorttling style recalcs.

* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):

LayoutTests:

* TestExpectations: Unskip
* platform/mac-wk2/TestExpectations: Unskip
* platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt:

Rebase. Focus timings depends on layout timings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 2db2ad6..f920d22 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,5 +1,18 @@
 2018-11-15  Antti Koivisto  <antti@apple.com>
 
+        REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191642
+
+        Reviewed by Zalan Bujtas.
+
+        * TestExpectations: Unskip
+        * platform/mac-wk2/TestExpectations: Unskip
+        * platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt:
+
+        Rebase. Focus timings depends on layout timings.
+
+2018-11-15  Antti Koivisto  <antti@apple.com>
+
         Remove fonts from CSSFontFaceSet safely
         https://bugs.webkit.org/show_bug.cgi?id=191676
 

diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index d559380..56e693d 100644 (file)
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -2950,6 +2950,3 @@ webkit.org/b/190032 imported/w3c/web-platform-tests/css/css-scoping/keyframes-00
 fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html [ Skip ]
 fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html [ Skip ]
 fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html [ Skip ]
-
-webkit.org/b/191642 fast/forms/access-key-case-insensitive.html [ Skip ]
-webkit.org/b/191642 fast/forms/access-key-mutated.html [ Skip ]
\ No newline at end of file

diff --git a/LayoutTests/platform/mac-wk2/TestExpectations b/LayoutTests/platform/mac-wk2/TestExpectations
index dd73e61..307ba11 100644 (file)
--- a/LayoutTests/platform/mac-wk2/TestExpectations
+++ b/LayoutTests/platform/mac-wk2/TestExpectations
@@ -907,6 +907,4 @@ webkit.org/b/183878 media/modern-media-controls/tracks-panel/tracks-panel-up-cli
 
 webkit.org/b/191644 [ Sierra ] fast/workers/worker-cloneport.html [ Pass Failure ]
 
-webkit.org/b/191642 accessibility/mac/selection-notification-focus-change.html [ Skip ]
-
 webkit.org/b/191658 [ Sierra Release ] fast/layers/no-clipping-overflow-hidden-added-after-transform.html [ Pass ImageOnlyFailure ]

diff --git a/LayoutTests/platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt b/LayoutTests/platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt
index ee62552..991575e 100644 (file)
--- a/LayoutTests/platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt
+++ b/LayoutTests/platform/mac-wk2/accessibility/mac/selection-notification-focus-change-expected.txt
@@ -7,9 +7,9 @@ PASS webArea.addNotificationListener(notificationCallback) is true
 eventSender.keyDown(tabCharacter);
 Received AXSelectedTextChanged
 PASS userInfo["AXTextSelectionChangedFocus"] is true
+Received AXFocusChanged
 Received AXSelectedTextChanged
 PASS userInfo["AXTextSelectionChangedFocus"] is true
-Received AXFocusChanged
 
 PASS accessibilityController.accessibleElementById("1").isFocusable is true
 accessibilityController.accessibleElementById("1").takeFocus()

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 29c1e1f..c9bb754 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,5 +1,17 @@
 2018-11-15  Antti Koivisto  <antti@apple.com>
 
+        REGRESSION(r238178): fast/forms/access-key-mutated.html and fast/forms/access-key-case-insensitive.html are timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191642
+
+        Reviewed by Zalan Bujtas.
+
+        Invalidate access key map even when thorttling style recalcs.
+
+        * dom/Document.cpp:
+        (WebCore::Document::scheduleStyleRecalc):
+
+2018-11-15  Antti Koivisto  <antti@apple.com>
+
         Remove fonts from CSSFontFaceSet safely
         https://bugs.webkit.org/show_bug.cgi?id=191676
 

diff --git a/Source/WebCore/dom/Document.cpp b/Source/WebCore/dom/Document.cpp
index 78c9a2f..35e712a 100644 (file)
--- a/Source/WebCore/dom/Document.cpp
+++ b/Source/WebCore/dom/Document.cpp
@@ -1804,6 +1804,9 @@ void Document::scheduleStyleRecalc()
 
     ASSERT(childNeedsStyleRecalc() || m_pendingStyleRecalcShouldForce);
 
+    // FIXME: Why on earth is this here? This is clearly misplaced.
+    invalidateAccessKeyMap();
+
     auto shouldThrottleStyleRecalc = [&] {
         if (m_pendingStyleRecalcShouldForce)
             return false;
@@ -1817,9 +1820,6 @@ void Document::scheduleStyleRecalc()
     if (shouldThrottleStyleRecalc())
         return;
 
-    // FIXME: Why on earth is this here? This is clearly misplaced.
-    invalidateAccessKeyMap();
-    
     m_styleRecalcTimer.startOneShot(0_s);
 
     InspectorInstrumentation::didScheduleStyleRecalculation(*this);