Reviewed by Darin Adler.
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 19 Jul 2010 20:03:32 +0000 (20:03 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 19 Jul 2010 20:03:32 +0000 (20:03 +0000)
        https://bugs.webkit.org/show_bug.cgi?id=42586
        Log all canceled authentication attempts in DumpRenderTree

        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
        It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
        case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/misc/401-alternative-content-expected.txt
LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/mac/ResourceLoadDelegate.mm
WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp

index df85a32..7122c6e 100644 (file)
@@ -2,6 +2,17 @@
 
         Reviewed by Darin Adler.
 
+        https://bugs.webkit.org/show_bug.cgi?id=42586
+        Log all canceled authentication attempts in DumpRenderTree
+
+        * http/tests/misc/401-alternative-content-expected.txt:
+        * http/tests/xmlhttprequest/failed-auth-expected.txt:
+        Added the new messages.
+
+2010-07-19  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Darin Adler.
+
         https://bugs.webkit.org/show_bug.cgi?id=40996
         Progress event should not be fired during synchronous XMLHttpRequest
 
index cc27c84..0332741 100644 (file)
@@ -1,3 +1,5 @@
+<unknown> - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
+<unknown> - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet
 Test for bug 13075: XMLHttpRequest with failed authentication should set status to 401.
 
 Sync, no credentials: OK
index 7fa4959..baad9ad 100644 (file)
@@ -1,3 +1,17 @@
+2010-07-19  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Darin Adler.
+
+        https://bugs.webkit.org/show_bug.cgi?id=42586
+        Log all canceled authentication attempts in DumpRenderTree
+
+        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
+        (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
+        * DumpRenderTree/win/ResourceLoadDelegate.cpp:
+        (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
+        It's important to know whether an auth sheet appeared. Added logging to "no preset credentials"
+        case.
+
 2010-07-19  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed, rolling out r63671.
index 10fa0f3..0855b83 100644 (file)
@@ -172,6 +172,9 @@ using namespace std;
 - (void)webView:(WebView *)wv resource:(id)identifier didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge fromDataSource:(WebDataSource *)dataSource
 {
     if (!gLayoutTestController->handlesAuthenticationChallenges()) {
+        NSString *string = [NSString stringWithFormat:@"%@ - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet", identifier];
+        printf("%s\n", [string UTF8String]);
+
         [[challenge sender] continueWithoutCredentialForAuthenticationChallenge:challenge];
         return;
     }
index 33ccd7f..825366a 100644 (file)
@@ -292,6 +292,7 @@ HRESULT STDMETHODCALLTYPE ResourceLoadDelegate::didReceiveAuthenticationChalleng
         return E_FAIL;
 
     if (!gLayoutTestController->handlesAuthenticationChallenges()) {
+        printf("%S - didReceiveAuthenticationChallenge - Simulating cancelled authentication sheet\n", descriptionSuitableForTestResult(identifier).c_str());
         sender->continueWithoutCredentialForAuthenticationChallenge(challenge);
         return S_OK;
     }