Remove noisy and unnecessary logs added in r241223
authorachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Feb 2019 01:50:34 +0000 (01:50 +0000)
committerachristensen@apple.com <achristensen@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Feb 2019 01:50:34 +0000 (01:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=194427

* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
Errors occur all the time in the XPC connection's event handler, like when a process terminates.
We don't need to print an "error" every time any process terminates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm

index 42533e3..4d18124 100644 (file)
@@ -1,3 +1,13 @@
+2019-02-11  Alex Christensen  <achristensen@webkit.org>
+
+        Remove noisy and unnecessary logs added in r241223
+        https://bugs.webkit.org/show_bug.cgi?id=194427
+
+        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+        (WebKit::ProcessLauncher::launchProcess):
+        Errors occur all the time in the XPC connection's event handler, like when a process terminates.
+        We don't need to print an "error" every time any process terminates.
+
 2019-02-11  Brian Burg  <bburg@apple.com>
 
         [Cocoa] Web Automation: client callbacks are not called if delegate does not override
index 66896f1..8964df3 100644 (file)
@@ -203,9 +203,6 @@ void ProcessLauncher::launchProcess()
     auto errorHandlerImpl = [weakProcessLauncher = makeWeakPtr(*this), listeningPort] (xpc_object_t event) {
         ASSERT(!event || xpc_get_type(event) == XPC_TYPE_ERROR);
 
-        if (event)
-            LOG_ERROR("Error launching auxiliary process: %s", xpc_dictionary_get_string(event, XPC_ERROR_KEY_DESCRIPTION));
-
         auto processLauncher = weakProcessLauncher.get();
         if (!processLauncher)
             return;