2010-04-29 Nikolas Zimmermann <nzimmermann@rim.com>
authorzimmermann@webkit.org <zimmermann@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Apr 2010 09:07:01 +0000 (09:07 +0000)
committerzimmermann@webkit.org <zimmermann@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 29 Apr 2010 09:07:01 +0000 (09:07 +0000)
        Reviewed by Maciej Stachowiak.

        REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
        https://bugs.webkit.org/show_bug.cgi?id=38307

        balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
        We now properly ignored the subtree. s/def/defs/ and the testcase works again.

        fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
        Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.

        Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
        I can now run those tests with --tolerance 0 without a problem.

        * fast/backgrounds/resources/balloon.svg: s/def/defs/
        * fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
        * fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
        * platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
        * platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
        * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@58489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/backgrounds/resources/balloon.svg
LayoutTests/fast/backgrounds/size/contain-and-cover-expected.checksum
LayoutTests/fast/backgrounds/size/contain-and-cover-expected.png
LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum
LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.png
LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum
LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.png
LayoutTests/platform/mac/fast/images/svg-as-tiled-background-expected.checksum
LayoutTests/platform/mac/fast/images/svg-as-tiled-background-expected.png
LayoutTests/platform/mac/fast/images/svg-background-partial-redraw-expected.checksum
LayoutTests/platform/mac/fast/images/svg-background-partial-redraw-expected.png

index 0819a78..ab02049 100644 (file)
@@ -1,3 +1,31 @@
+2010-04-29  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        Reviewed by Maciej Stachowiak.
+
+        REGRESSION: gradient background of LayoutTests/fast/backgrounds/resources/balloon.svg fails to draw
+        https://bugs.webkit.org/show_bug.cgi?id=38307
+
+        balloon.svg is broken, it contains a <def> section, instead of a <defs> section.
+        We now properly ignored the subtree. s/def/defs/ and the testcase works again.
+
+        fast/backgrounds/svg-as-background-2.html even properly draws the gradient background instead of pure red color.
+        Combined with Simons SVGImage repaint fixes, we have a nice progression in this area.
+
+        Updated some fast/*expected.png files, that showed a 0.01% difference on my system. Probably a CG difference,
+        I can now run those tests with --tolerance 0 without a problem.
+
+        * fast/backgrounds/resources/balloon.svg: s/def/defs/
+        * fast/backgrounds/size/contain-and-cover-expected.checksum: Updated for marginal differences.
+        * fast/backgrounds/size/contain-and-cover-expected.png: Ditto.
+        * platform/mac/fast/backgrounds/svg-as-background-2-expected.checksum: Huge update, no more red, but a nice gradient.
+        * platform/mac/fast/backgrounds/svg-as-background-2-expected.png: Ditto.
+        * platform/mac/fast/backgrounds/svg-as-background-6-expected.checksum: Updated for marginal differences.
+        * platform/mac/fast/backgrounds/svg-as-background-6-expected.png: Ditto.
+        * platform/mac/fast/images/svg-as-tiled-background-expected.checksum: Reflect the current state: it's green now, no more red.
+        * platform/mac/fast/images/svg-as-tiled-background-expected.png: Ditto.
+        * platform/mac/fast/images/svg-background-partial-redraw-expected.checksum: Updated for marginal differences.
+        * platform/mac/fast/images/svg-background-partial-redraw-expected.png: Ditto.
+
 2010-04-29  Fumitoshi Ukai  <ukai@chromium.org>
 
         Unreviewed, test expectations update.
index 20c0b34..48d9e46 100644 (file)
@@ -180,7 +180,7 @@ function color(xr,xg,xb){
 }
        //]]>
 </script>
-<def>
+<defs>
 <path id="Q" stroke="black" stroke-width="3"/>
 <linearGradient id="backsky" x1="0%" y1="0%" x2="0%" y2="100%">
        <stop offset="0" stop-color="#888"/>
@@ -219,7 +219,7 @@ function color(xr,xg,xb){
        <stop offset=".70" stop-color="#c86"/>
        <stop offset=".90"  stop-color="#bc7"/>
 </linearGradient> 
-</def>
+</defs>
 <rect  height="100%" width="100%" opacity="1" fill="url(#backsky)"/>
 
 <path id="peaks2" d="M 0 500 400 400 800 500 z" fill="url(#peak2)" />
index 8b65a33..2896fec 100644 (file)
Binary files a/LayoutTests/fast/backgrounds/size/contain-and-cover-expected.png and b/LayoutTests/fast/backgrounds/size/contain-and-cover-expected.png differ
index 06e8a70..d63b883 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.png and b/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-2-expected.png differ
index ce87010..c7990d4 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.png and b/LayoutTests/platform/mac/fast/backgrounds/svg-as-background-6-expected.png differ
index eadfc81..a56e38c 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/images/svg-as-tiled-background-expected.png and b/LayoutTests/platform/mac/fast/images/svg-as-tiled-background-expected.png differ
index 134fa9f..e9086ca 100644 (file)
Binary files a/LayoutTests/platform/mac/fast/images/svg-background-partial-redraw-expected.png and b/LayoutTests/platform/mac/fast/images/svg-background-partial-redraw-expected.png differ