Turn on Pointer Events by default for iOS
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Jan 2019 23:15:59 +0000 (23:15 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 7 Jan 2019 23:15:59 +0000 (23:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193214
<rdar://problem/46974878>

Reviewed by Wenson Hsieh.

LayoutTests/imported/w3c:

Update expected results.

* web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt:
* web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt:
* web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt:

Source/WebKit:

Turn on Pointer Events.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS.

LayoutTests:

Skip the pointer events tests everywhere but iOS.

* TestExpectations:
* platform/ios-wk1/TestExpectations:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt
LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt
LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt
LayoutTests/platform/ios-wk1/TestExpectations
LayoutTests/platform/ios-wk2/TestExpectations
LayoutTests/platform/mac-wk1/TestExpectations
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml
Source/WebKit/Shared/WebPreferencesDefaultValues.h

index e4d47ad..3a64ed7 100644 (file)
@@ -1,3 +1,18 @@
+2019-01-07  Dean Jackson  <dino@apple.com>
+
+        Turn on Pointer Events by default for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=193214
+        <rdar://problem/46974878>
+
+        Reviewed by Wenson Hsieh.
+
+        Skip the pointer events tests everywhere but iOS.
+
+        * TestExpectations:
+        * platform/ios-wk1/TestExpectations:
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk1/TestExpectations:
+
 2019-01-07  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: extend XHR breakpoints to work with fetch
index beb25c5..6447318 100644 (file)
@@ -446,6 +446,10 @@ fast/web-share [ Skip ]
 # This test was created to test a mac-wk2 bugfix
 fast/animation/request-animation-frame-in-two-pages.html [ Skip ]
 
+# Only supported on iOS
+imported/w3c/web-platform-tests/pointerevents [ Skip ]
+pointerevents [ Skip ]
+
 #//////////////////////////////////////////////////////////////////////////////////////////
 # End platform-specific tests.
 #//////////////////////////////////////////////////////////////////////////////////////////
index ece7759..0a501ef 100644 (file)
@@ -1,3 +1,17 @@
+2019-01-07  Dean Jackson  <dino@apple.com>
+
+        Turn on Pointer Events by default for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=193214
+        <rdar://problem/46974878>
+
+        Reviewed by Wenson Hsieh.
+
+        Update expected results.
+
+        * web-platform-tests/pointerevents/extension/pointerevent_touch-action-verification-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_touch-action-illegal-expected.txt:
+        * web-platform-tests/pointerevents/pointerevent_touch-action-verification-expected.txt:
+
 2019-01-07  Youenn Fablet  <youenn@apple.com>
 
         Resync WPT fetch tests to 834eac4
index c5b110d..b04398c 100644 (file)
@@ -7,45 +7,45 @@ touch-action: basic verification
 The following pointer types were detected: .
 
 
-FAIL default assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x"
-FAIL explicit-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left"
-FAIL explicit-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right"
-FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y"
-FAIL explicit-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-up"
-FAIL explicit-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-down"
-FAIL explicit-pinch-zoom assert_equals: expected (undefined) undefined but got (string) "pinch-zoom"
-FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-pan-left-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-left pan-up"
-FAIL explicit-pan-left-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-left pan-down"
-FAIL explicit-pan-right-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-right pan-up"
-FAIL explicit-pan-right-pan-down assert_equals: expected (undefined) undefined but got (string) "pan-right pan-down"
-FAIL explicit-pan-up-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left pan-up"
-FAIL explicit-pan-up-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right pan-up"
-FAIL explicit-pan-down-pan-left assert_equals: expected (undefined) undefined but got (string) "pan-left pan-down"
-FAIL explicit-pan-down-pan-right assert_equals: expected (undefined) undefined but got (string) "pan-right pan-down"
-FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected (undefined) undefined but got (string) "pan-x pan-up pinch-zoom"
-FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "manipulation"
-FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation"
-FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-14 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto"
+PASS default 
+FAIL stylesheet-none assert_equals: expected "auto" but got "none"
+PASS explicit-auto 
+FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
+FAIL explicit-pan-left assert_equals: expected "auto" but got "pan-left"
+FAIL explicit-pan-right assert_equals: expected "auto" but got "pan-right"
+FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
+FAIL explicit-pan-up assert_equals: expected "auto" but got "pan-up"
+FAIL explicit-pan-down assert_equals: expected "auto" but got "pan-down"
+FAIL explicit-pinch-zoom assert_equals: expected "auto" but got "pinch-zoom"
+FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
+FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
+FAIL explicit-pan-left-pan-up assert_equals: expected "auto" but got "pan-left pan-up"
+FAIL explicit-pan-left-pan-down assert_equals: expected "auto" but got "pan-left pan-down"
+FAIL explicit-pan-right-pan-up assert_equals: expected "auto" but got "pan-right pan-up"
+FAIL explicit-pan-right-pan-down assert_equals: expected "auto" but got "pan-right pan-down"
+FAIL explicit-pan-up-pan-left assert_equals: expected "auto" but got "pan-left pan-up"
+FAIL explicit-pan-up-pan-right assert_equals: expected "auto" but got "pan-right pan-up"
+FAIL explicit-pan-down-pan-left assert_equals: expected "auto" but got "pan-left pan-down"
+FAIL explicit-pan-down-pan-right assert_equals: expected "auto" but got "pan-right pan-down"
+FAIL explicit-pinch-zoom-pan-x-pan-up assert_equals: expected "auto" but got "pan-x pan-up pinch-zoom"
+FAIL explicit-pinch-zoom-pan-x-pan-y assert_equals: expected "auto" but got "manipulation"
+PASS explicit-manipulation 
+FAIL explicit-none assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-1 
+FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-3 
+PASS explicit-invalid-4 
+PASS explicit-invalid-5 
+PASS explicit-invalid-6 
+PASS explicit-invalid-7 
+PASS explicit-invalid-8 
+PASS explicit-invalid-9 
+PASS explicit-invalid-10 
+PASS explicit-invalid-11 
+PASS explicit-invalid-12 
+PASS explicit-invalid-13 
+PASS explicit-invalid-14 
+PASS not-inherited 
+FAIL inherit assert_equals: expected "auto" but got "none"
+PASS initial 
 
index 563bd20..c02deb3 100644 (file)
@@ -7,7 +7,7 @@ touch-action: none
 The following pointer types were detected: (none).
 
 
-FAIL 'pan-x none' is corrected properly assert_true: 'pan-x none' is corrected properly expected true got false
-FAIL 'pan-y none' is corrected properly assert_true: 'pan-y none' is corrected properly expected true got false
-FAIL 'auto none' is corrected properly assert_true: 'auto none' is corrected properly expected true got false
+PASS 'pan-x none' is corrected properly 
+PASS 'pan-y none' is corrected properly 
+PASS 'auto none' is corrected properly 
 
index 771bba1..123f93e 100644 (file)
@@ -5,29 +5,29 @@ Test Description: Test will automatically check parsing behaviour of various tou
 touch-action: basic verification
 
 
-FAIL default assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL stylesheet-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-auto assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x"
-FAIL explicit-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-y"
-FAIL explicit-pan-x-pan-y assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-pan-y-pan-x assert_equals: expected (undefined) undefined but got (string) "pan-x pan-y"
-FAIL explicit-manipulation assert_equals: expected (undefined) undefined but got (string) "manipulation"
-FAIL explicit-none assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-1 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-2 assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL explicit-invalid-3 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-4 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-5 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-6 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-7 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-8 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-9 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-10 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-11 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-12 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL explicit-invalid-13 assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL not-inherited assert_equals: expected (undefined) undefined but got (string) "auto"
-FAIL inherit assert_equals: expected (undefined) undefined but got (string) "none"
-FAIL initial assert_equals: expected (undefined) undefined but got (string) "auto"
+PASS default 
+FAIL stylesheet-none assert_equals: expected "auto" but got "none"
+PASS explicit-auto 
+FAIL explicit-pan-x assert_equals: expected "auto" but got "pan-x"
+FAIL explicit-pan-y assert_equals: expected "auto" but got "pan-y"
+FAIL explicit-pan-x-pan-y assert_equals: expected "auto" but got "pan-x pan-y"
+FAIL explicit-pan-y-pan-x assert_equals: expected "auto" but got "pan-x pan-y"
+PASS explicit-manipulation 
+FAIL explicit-none assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-1 
+FAIL explicit-invalid-2 assert_equals: expected "auto" but got "none"
+PASS explicit-invalid-3 
+PASS explicit-invalid-4 
+PASS explicit-invalid-5 
+PASS explicit-invalid-6 
+PASS explicit-invalid-7 
+PASS explicit-invalid-8 
+PASS explicit-invalid-9 
+PASS explicit-invalid-10 
+PASS explicit-invalid-11 
+PASS explicit-invalid-12 
+PASS explicit-invalid-13 
+PASS not-inherited 
+FAIL inherit assert_equals: expected "auto" but got "none"
+PASS initial 
 
index f4f8266..58a1864 100644 (file)
@@ -23,10 +23,6 @@ webrtc [ Skip ]
 # Not supported on WK1
 media/no-fullscreen-when-hidden.html [ Skip ]
 
-# Skip pointerevents on WK1
-pointerevents [ Skip ]
-imported/w3c/web-platform-tests/pointerevents [ Skip ]
-
 # Datalist is unsupported in WK1
 fast/forms/datalist [ WontFix ]
 imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]
index c36183d..6f001e8 100644 (file)
@@ -55,6 +55,9 @@ applicationmanifest/ [ Pass ]
 
 webkit.org/b/187773 http/tests/webAPIStatistics [ Pass ]
 
+imported/w3c/web-platform-tests/pointerevents [ Pass ]
+pointerevents [ Pass ]
+
 #//////////////////////////////////////////////////////////////////////////////////////////
 # End platform-specific directories.
 #//////////////////////////////////////////////////////////////////////////////////////////
index 754d1ce..e3f2645 100644 (file)
@@ -166,10 +166,6 @@ webrtc/datachannel [ Pass ]
 webrtc/datachannel/mdns-ice-candidates.html [ Skip ]
 imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-offer.html [ Failure ]
 
-# Skip pointerevents on WK1
-pointerevents [ Skip ]
-imported/w3c/web-platform-tests/pointerevents [ Skip ]
-
 # Datalist is unsupported in WK1
 fast/forms/datalist [ WontFix ]
 imported/w3c/web-platform-tests/html/semantics/forms/the-datalist-element [ WontFix ]
index fcae4d5..1319dde 100644 (file)
@@ -1,3 +1,16 @@
+2019-01-07  Dean Jackson  <dino@apple.com>
+
+        Turn on Pointer Events by default for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=193214
+        <rdar://problem/46974878>
+
+        Reviewed by Wenson Hsieh.
+
+        Turn on Pointer Events.
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesDefaultValues.h: Make a new #define for iOS.
+
 2019-01-07  Alex Christensen  <achristensen@webkit.org>
 
         Remove use of NetworkProcess::singleton in ServiceWorker code
index 20614ae..a640597 100644 (file)
@@ -1240,7 +1240,7 @@ VisualViewportAPIEnabled:
 
 PointerEventsEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: DEFAULT_POINTER_EVENTS_ENABLED
   humanReadableName: "Pointer Events"
   humanReadableDescription: "Enable Pointer Events"
   webcoreBinding: RuntimeEnabledFeatures
index 1d07882..0a52167 100644 (file)
 #define DEFAULT_SERVICE_WORKERS_ENABLED false
 #endif
 
+#if PLATFORM(IOS_FAMILY)
+#define DEFAULT_POINTER_EVENTS_ENABLED true
+#else
+#define DEFAULT_POINTER_EVENTS_ENABLED false
+#endif
+
 #if PLATFORM(MAC) || PLATFORM(IOS)
 #define DEFAULT_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION_ENABLED true
 #else